Skip to content

Commit 9f5a3cc

Browse files
committed
Parameterize service and routes consistently
1 parent 9fd79a0 commit 9f5a3cc

File tree

1 file changed

+16
-11
lines changed

1 file changed

+16
-11
lines changed

openshift/templates/nodejs.json

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"kind": "Service",
1616
"apiVersion": "v1beta3",
1717
"metadata": {
18-
"name": "nodejs-frontend",
18+
"name": "${FRONTEND_SERVICE_NAME}",
1919
"creationTimestamp": null
2020
},
2121
"spec": {
@@ -29,7 +29,7 @@
2929
}
3030
],
3131
"selector": {
32-
"name": "nodejs-frontend"
32+
"name": "${FRONTEND_SERVICE_NAME}"
3333
},
3434
"portalIP": "",
3535
"type": "ClusterIP",
@@ -43,14 +43,14 @@
4343
"kind": "Route",
4444
"apiVersion": "v1beta3",
4545
"metadata": {
46-
"name": "frontend-route",
46+
"name": "${FRONTEND_ROUTE}",
4747
"creationTimestamp": null
4848
},
4949
"spec": {
5050
"host" : "${FRONTEND_ROUTE}",
5151
"to": {
5252
"kind" : "Service",
53-
"name" : "nodejs-frontend"
53+
"name" : "${FRONTEND_SERVICE_NAME}"
5454
}
5555
}
5656
},
@@ -112,7 +112,7 @@
112112
"source": {
113113
"type": "Git",
114114
"git": {
115-
"uri": "${GITHUB_URL}"
115+
"uri": "${SOURCE_REPOSITORY_URL}"
116116
}
117117
},
118118
"strategy": {
@@ -141,7 +141,7 @@
141141
"kind": "DeploymentConfig",
142142
"apiVersion": "v1beta3",
143143
"metadata": {
144-
"name": "nodejs-frontend",
144+
"name": "nodejs-example",
145145
"creationTimestamp": null
146146
},
147147
"spec": {
@@ -172,13 +172,13 @@
172172
],
173173
"replicas": 1,
174174
"selector": {
175-
"name": "nodejs-frontend"
175+
"name": "nodejs-example"
176176
},
177177
"template": {
178178
"metadata": {
179179
"creationTimestamp": null,
180180
"labels": {
181-
"name": "nodejs-frontend"
181+
"name": "nodejs-example"
182182
}
183183
},
184184
"spec": {
@@ -213,14 +213,19 @@
213213
"parameters": [
214214
{
215215
"name": "SOURCE_REPOSITORY_URL",
216-
"description": "The URL with your Node.js application source code.",
216+
"description": "The URL with your Node.js application source code",
217217
"value": "https://github.com/openshift/nodejs-ex.git"
218218
},
219+
{
220+
"name": "FRONTEND_SERVICE_NAME",
221+
"description": "Frontend service name",
222+
"value": "nodejs"
223+
},
219224
{
220225
"name": "FRONTEND_ROUTE",
221-
"description": "The exposed hostname that will route to the Node.js service.",
226+
"description": "The exposed hostname that will route to the Node.js service",
222227
"value": "nodejs.apps"
223-
}
228+
}
224229
],
225230
"labels": {
226231
"template": "nodejs-example"

0 commit comments

Comments
 (0)