Remove 'version' label from Dockerfile.rhel10 #621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konflux build pipeline needs it. See https://issues.redhat.com/browse/RHELMISC-17288 Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Pull Request validationFailed🔴 Review - Missing review from a member (1 required) Success🟢 CI - All checks have passed |
|
[test] |
Testing Farm results
|
fila43
reviewed
Sep 11, 2025
| com.redhat.component="{{ spec.redhat_component }}" \ | ||
| {% if spec.version not in ["9.4", "9.5", "9.6"] %} | ||
| {% if config.os.id == "rhel" and spec.prod != "rhel10" %} | ||
| version="1" \ |
There was a problem hiding this comment.
Just out of curiosity, why are you using such a complicated construct if you set version=1 in both cases?
otherwise LGTM
There was a problem hiding this comment.
This change is affected only for RHEL10. Not rhel8, rhel9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove 'version' label from Dockerfile.rhel10
Konflux build pipeline needs it.
See https://issues.redhat.com/browse/RHELMISC-17288