Skip to content

Move test_run_binary_application to 'upstream' tests #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
phracek merged 5 commits into from
Mar 24, 2025
Merged

Move test_run_binary_application to 'upstream' tests #475

phracek merged 5 commits into from
Mar 24, 2025

Conversation

@phracek
Copy link
Member

@phracek phracek commented Feb 25, 2025 •
edited by github-actions bot
Loading

Move test_run_binary_application to 'upstream' tests

Add support for testing 'test-upstream'

Also added support for testing 'upstream' utilities by calling '[test-upstream]'

@phracek

This comment was marked as outdated.

Sign in to view
@github-actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
CentOS Stream 10 - 22-minimalCentOS-Stream-10x86_64❌ error18.03.2025 14:35:386min 7stest pipeline
Fedora - 20-minimalFedora-latestx86_64✅ passed18.03.2025 14:35:379min 44stest pipeline
CentOS Stream 10 - 22CentOS-Stream-10x86_64✅ passed18.03.2025 14:35:3810min 58stest pipeline
Fedora - 18-minimalFedora-latestx86_64✅ passed18.03.2025 14:35:419min 54stest pipeline
Fedora - 20Fedora-latestx86_64✅ passed18.03.2025 14:45:4111min 6stest pipeline
Fedora - 18Fedora-latestx86_64✅ passed18.03.2025 14:35:3711min 14stest pipeline
CentOS Stream 9 - 20-minimalCentOS-Stream-9x86_64✅ passed18.03.2025 14:35:559min 52stest pipeline
Fedora - 22Fedora-latestx86_64✅ passed18.03.2025 14:35:3911min 15stest pipeline
CentOS Stream 9 - 20CentOS-Stream-9x86_64✅ passed18.03.2025 14:42:2910min 27stest pipeline
RHEL9 - 20RHEL-9.4.0-Nightlyx86_64✅ passed18.03.2025 14:35:3916min 20stest pipeline
RHEL9 - 18-minimalRHEL-9.4.0-Nightlyx86_64✅ passed18.03.2025 14:46:0216min 6stest pipeline
RHEL9 - 20-minimalRHEL-9.4.0-Nightlyx86_64✅ passed18.03.2025 14:45:5315min 48stest pipeline
RHEL9 - 18RHEL-9.4.0-Nightlyx86_64✅ passed18.03.2025 14:35:3815min 57stest pipeline
RHEL10 - 22RHEL-10-Nightlyx86_64✅ passed18.03.2025 14:35:3917min 1stest pipeline
RHEL8 - 20-minimalRHEL-8.10.0-Nightlyx86_64✅ passed18.03.2025 14:35:4718min 36stest pipeline
Fedora - 22-minimalFedora-latestx86_64✅ passed18.03.2025 14:35:569min 29stest pipeline
RHEL8 - 20RHEL-8.10.0-Nightlyx86_64✅ passed18.03.2025 14:35:5119min 15stest pipeline
RHEL9 - 22-minimalRHEL-9.4.0-Nightlyx86_64✅ passed18.03.2025 14:35:5115min 11stest pipeline
RHEL10 - 22-minimalRHEL-10-Nightlyx86_64✅ passed18.03.2025 14:35:3715min 30stest pipeline
RHEL8 - 22-minimalRHEL-8.10.0-Nightlyx86_64✅ passed18.03.2025 14:35:3919min 36stest pipeline
RHEL9 - 22RHEL-9.4.0-Nightlyx86_64✅ passed18.03.2025 14:36:1116min 52stest pipeline
RHEL8 - 18-minimalRHEL-8.10.0-Nightlyx86_64✅ passed18.03.2025 14:35:3718min 53stest pipeline
RHEL8 - 22RHEL-8.10.0-Nightlyx86_64✅ passed18.03.2025 14:35:4919min 47stest pipeline
RHEL8 - 18RHEL-8.10.0-Nightlyx86_64✅ passed18.03.2025 14:35:5118min 32stest pipeline

@github-actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

Pull Request validation

Failed

🔴 Failed or pending statuses - Testing Farm - CentOS Stream 10 - 22-minimal[error]
🔴 Review - Missing review from a member (1 required)

@phracek

This comment was marked as outdated.

Sign in to view
@phracek

This comment was marked as outdated.

Sign in to view
@phracek phracek force-pushed the move_run_binary_to_upstream_tests branch from 8702f04 to 955de02 Compare February 25, 2025 12:15
@phracek
Copy link
Member Author

phracek commented Feb 25, 2025

[test]

@phracek
Copy link
Member Author

phracek commented Feb 26, 2025

Let's see what's happened with traces.

[test]

@phracek phracek force-pushed the move_run_binary_to_upstream_tests branch from 5bacf12 to 92f4e73 Compare February 26, 2025 11:58
@phracek
Copy link
Member Author

phracek commented Feb 26, 2025

Let's remove debugging traces and re-run tests again

[test]

@phracek phracek mentioned this pull request Mar 18, 2025
Merged
phracek added 3 commits March 18, 2025 10:50
@phracek
Move test_run_binary_application to 'upstream' tests
680ac28 
Add support for testing 'test-upstream'
 RHEL7 is already obsoleted. Remove conditions

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Add more traces to docker inspect
4338b52 
Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Redirect docker inspect output to /dev/null
766d2a4 
Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek phracek force-pushed the move_run_binary_to_upstream_tests branch from 92f4e73 to 766d2a4 Compare March 18, 2025 09:50
@phracek
Copy link
Member Author

phracek commented Mar 18, 2025

rebased against master

[test]

@phracek
Copy link
Member Author

phracek commented Mar 18, 2025

The complete 'binary' suite was moved to test-upstream.

[test]

@phracek
DO not call 'cleanup' in 'run-upstream'
068c963 
Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member Author

phracek commented Mar 18, 2025

CentOS Streeam 10 - 20-minimal failure is caused by this one:

CentOS Stream 10 - BaseOS                        48 MB/s | 6.6 MB     00:00    
CentOS Stream 10 - AppStream                     24 MB/s | 3.1 MB     00:00    
CentOS Stream 10 - Extras packages               35 kB/s | 3.8 kB     00:00    
Package findutils-1:4.10.0-5.el10.x86_64 is already installed.
Package tar-2:1.35-7.el10.x86_64 is already installed.
Error: 
 Problem: package nodejs-full-i18n-1:22.13.1-2.el10.x86_64 from appstream requires nodejs(x86-64) = 1:22.13.1-2.el10, but none of the providers can be installed
  - cannot install both nodejs-1:22.13.1-2.el10.x86_64 from appstream and nodejs-1:22.13.1-1.el10.x86_64 from appstream
  - cannot install the best candidate for the job
(try to add '--allowerasing' to command line to replace conflicting packages or '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)

Are you aware of it? @khardix @hhorak @jackorp ?

The rest of the tests look good.

[test][test-upstream]

@khardix
Copy link
Contributor

khardix commented Mar 18, 2025 •
edited
Loading

I managed to break compose last week, so this is probably a fallout of that. Although the error is weird – why does it attempt to install two versions of the same package at once?

EDIT: When trying to install nodejs22 (specifically), for some reason dnf selects the older version (-1.el10 release) as the better candidate than the newer (-2.el10 release). If you ask just for nodejs, it installs the newer version. Is the selection order different when using virtual provides? 👀

@phracek phracek mentioned this pull request Mar 19, 2025
Closed
@khardix
Copy link
Contributor

khardix commented Mar 24, 2025

The Centos 10 stream failure is a separate issue, being handled in #478. Otherwise this looks good to me.

hhorak
hhorak approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@hhorak hhorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The binary test makes troubles long-term, and failures almost never lead to the change in the container image, let's rather have slightly less coverage, but more useful feedback from the tests. LGTM

@phracek phracek merged commit 3105cd1 into master Mar 24, 2025
24 of 25 checks passed
@phracek phracek deleted the move_run_binary_to_upstream_tests branch March 24, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hhorak hhorak hhorak approved these changes

@khardix khardix khardix approved these changes

Assignees

No one assigned

Labels

pr/failing-ci pr/missing-review READY-to-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@phracek @khardix @hhorak