Skip to content

Enable nodejs24 for cXs and fix RHEL10 Dockerfiles #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hhorak merged 4 commits into from
Sep 22, 2025
Merged

Enable nodejs24 for cXs and fix RHEL10 Dockerfiles #500

hhorak merged 4 commits into from
Sep 22, 2025

Conversation

@hhorak
Copy link
Member

@hhorak hhorak commented Sep 5, 2025 •
edited by github-actions bot
Loading

No description provided.

@hhorak
Copy link
Member Author

hhorak commented Sep 5, 2025

[test]

@github-actions
Copy link

github-actions bot commented Sep 5, 2025 •
edited
Loading

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
RHEL9 - 24RHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 12:20:4220min 57stest pipeline
RHEL10 - 22RHEL-10-Nightlyx86_64✅ passed15.09.2025 13:05:1017min 8stest pipeline
RHEL9 - FIPS Enabled - 22RHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 11:46:4027min 55stest pipeline
RHEL9 - 22-minimalRHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 12:22:2319min 27stest pipeline
RHEL10 - 22-minimalRHEL-10-Nightlyx86_64✅ passed10.09.2025 12:37:2715min 30stest pipeline
RHEL9 - FIPS Enabled - 24-minimalRHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 11:33:4226min 32stest pipeline
RHEL9 - FIPS Enabled - 20-minimalRHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 12:02:0324min 11stest pipeline
RHEL10 - FIPS Enabled - 24RHEL-10-Nightlyx86_64❌ error15.09.2025 13:05:0412min 46stest pipeline
CentOS Stream 9 - 24-minimalCentOS-Stream-9x86_64✅ passed10.09.2025 12:28:5812min 4stest pipeline
Fedora - 24Fedora-latestx86_64✅ passed15.09.2025 13:07:2010min 29stest pipeline
CentOS Stream 9 - 24CentOS-Stream-9x86_64✅ passed10.09.2025 12:00:3013min 4stest pipeline
CentOS Stream 10 - 22CentOS-Stream-10x86_64✅ passed15.09.2025 13:05:1012min 32stest pipeline
CentOS Stream 10 - 24CentOS-Stream-10x86_64✅ passed10.09.2025 12:27:2412min 51stest pipeline
Fedora - 20-minimalFedora-latestx86_64✅ passed15.09.2025 13:19:209min 5stest pipeline
RHEL10 - FIPS Enabled - 24-minimalRHEL-10-Nightlyx86_64❌ error15.09.2025 13:05:0213min 2stest pipeline
RHEL10 - FIPS Enabled - 22-minimalRHEL-10-Nightlyx86_64✅ passed15.09.2025 13:05:0317min 39stest pipeline
CentOS Stream 10 - 22-minimalCentOS-Stream-10x86_64✅ passed10.09.2025 12:38:4510min 34stest pipeline
Fedora - 24-minimalFedora-latestx86_64✅ passed15.09.2025 13:07:038min 59stest pipeline
Fedora - 22Fedora-latestx86_64✅ passed15.09.2025 13:14:0411min 34stest pipeline
CentOS Stream 9 - 20CentOS-Stream-9x86_64✅ passed10.09.2025 11:47:5012min 32stest pipeline
Fedora - 20Fedora-latestx86_64✅ passed10.09.2025 11:33:4811min 18stest pipeline
CentOS Stream 10 - 24-minimalCentOS-Stream-10x86_64✅ passed15.09.2025 13:06:0010min 49stest pipeline
CentOS Stream 9 - 20-minimalCentOS-Stream-9x86_64✅ passed10.09.2025 12:25:2511min 32stest pipeline
RHEL9 - 20RHEL-9.6.0-Nightlyx86_64❌ error10.09.2025 11:33:4221min 40stest pipeline
RHEL9 - FIPS Enabled - 24RHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 11:54:0825min 18stest pipeline
RHEL9 - 22RHEL-9.6.0-Nightlyx86_64✅ passed15.09.2025 13:05:3723min 35stest pipeline
RHEL9 - 24-minimalRHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 12:41:0219min 4stest pipeline
RHEL10 - 24RHEL-10-Nightlyx86_64❌ error15.09.2025 13:11:4911min 20stest pipeline
RHEL10 - 24-minimalRHEL-10-Nightlyx86_64❌ error10.09.2025 12:02:1312min 1stest pipeline
RHEL8 - 22RHEL-8.10.0-Nightlyx86_64✅ passed10.09.2025 12:02:5420min 5stest pipeline
RHEL8 - 20RHEL-8.10.0-Nightlyx86_64✅ passed10.09.2025 12:35:2219min 53stest pipeline
RHEL8 - 20-minimalRHEL-8.10.0-Nightlyx86_64✅ passed10.09.2025 12:02:0219min 21stest pipeline
RHEL10 - FIPS Enabled - 22RHEL-10-Nightlyx86_64✅ passed15.09.2025 13:05:0218min 55stest pipeline
RHEL9 - 20-minimalRHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 12:37:5019min 3stest pipeline
RHEL8 - 22-minimalRHEL-8.10.0-Nightlyx86_64✅ passed10.09.2025 11:46:2818min 11stest pipeline
RHEL9 - FIPS Enabled - 22-minimalRHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 11:44:4323min 10stest pipeline
RHEL9 - FIPS Enabled - 20RHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 11:56:0324min 40stest pipeline
Fedora - 22-minimalFedora-latestx86_64✅ passed10.09.2025 11:33:519min 24stest pipeline

@phracek
Copy link
Member

phracek commented Sep 8, 2025

@hhorak Can you please also fix nodejs-24 and calling 'node' in Dockerfile? It should be on RHEL10 'node-24 -v' instead of 'node -v'. Thanks.

I guess, it can be done as a part of this pull request.

@hhorak
Copy link
Member Author

hhorak commented Sep 8, 2025

[test]

@phracek
Copy link
Member

phracek commented Sep 8, 2025

Also thing about one think. In our tests we used 'node' command, but RHEL10 provides 'node-24' instead of 'node'.
See https://github.com/sclorg/s2i-nodejs-container/blob/master/24/Dockerfile.rhel10#L60.

This is missing in 24-minimal/Dockerfile.rhel10. https://github.com/sclorg/s2i-nodejs-container/blob/master/24-minimal/Dockerfile.rhel10#L55

@phracek phracek self-requested a review September 8, 2025 09:57
phracek
phracek requested changes Sep 8, 2025
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my proposals. Thanks.

@hhorak
Copy link
Member Author

hhorak commented Sep 10, 2025 •
edited
Loading

@hhorak Can you please also fix nodejs-24 and calling 'node' in Dockerfile? It should be on RHEL10 'node-24 -v' instead of 'node -v'. Thanks.

This is a real issue, but I'll fix it differently. We need to have node and other binaries without a version, so instead of changing the check, I think I need to use rm -f instead of rm only when removing /usr/bin/node and others, as those do not exist before creating the symlink. Or maybe removing the rm call entirely.

@hhorak
Copy link
Member Author

hhorak commented Sep 10, 2025

[test]

@hhorak
Copy link
Member Author

hhorak commented Sep 10, 2025

[test]

1 similar comment
@phracek
Copy link
Member

phracek commented Sep 15, 2025

[test]

@phracek
Copy link
Member

phracek commented Sep 15, 2025

After moving to Nightly RHEL10 devel packages. Let's test it again

[test]

@phracek
Copy link
Member

phracek commented Sep 16, 2025

[test-all]

@phracek
Copy link
Member

phracek commented Sep 16, 2025

Let's re-run tests

[test-all]

@phracek
Copy link
Member

phracek commented Sep 17, 2025

Let's try to test one-by-one.

[test]

@phracek
Copy link
Member

phracek commented Sep 17, 2025

[test-openshift]

phracek
phracek approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. THanks for allowing NodeJS 24.

@phracek
Copy link
Member

phracek commented Sep 18, 2025

If you don't mind, I would merge it as soon as at least container tests passed.

[test-openshift]
[test]

@phracek
Copy link
Member

phracek commented Sep 18, 2025

[test-openshift]

Container tests looks good.

@phracek
Copy link
Member

phracek commented Sep 18, 2025

RHEL10 24-minimal failed with this reason:

STEP 13/13: LABEL "io.openshift.builder-version"="\"06bb08d\"" "io.openshift.builder-version"="\"06bb08d\""
COMMIT
--> 0290af8913b8
0290af8913b80835b3fcd7f8c8b3ab7f5b9d12f62a0e72ecdf3e9605a9df7726
nodejs 24 => 0290af8913b80835b3fcd7f8c8b3ab7f5b9d12f62a0e72ecdf3e9605a9df7726
nodejs 24-minimal => Error: building at STEP "RUN INSTALL_PKGS="nodejs$NODEJS_VERSION nodejs-nodemon nodejs$NODEJS_VERSION-full-i18n nodejs$NODEJS_VERSION-npm findutils tar which" &&     microdnf -y --nodocs --setopt=install_weak_deps=0 install $INSTALL_PKGS &&     microdnf clean all &&     ln -s /usr/bin/node-$NODEJS_VERSION /usr/bin/node &&     ln -s /usr/bin/npm-$NODEJS_VERSION /usr/bin/npm &&     ln -s /usr/bin/npx-$NODEJS_VERSION /usr/bin/npx &&     node -v | grep -qe "^v$NODEJS_VERSION\." && echo "Found VERSION $NODEJS_VERSION" &&     rm -rf /mnt/rootfs/var/cache/* /mnt/rootfs/var/log/dnf* /mnt/rootfs/var/log/yum.*": while running runtime: exit status 1
make[1]: Leaving directory '/root/sclorg/s2i-nodejs-container'
VERSIONS="20 20-minimal 22 22-minimal 24 24-minimal" SKIP_SQUASH=1 OS=rhel10 CLEAN_AFTER= DOCKER_BUILD_CONTEXT=. OPENSHIFT_NAMESPACES="" CUSTOM_REPO="" REGISTRY="""" TEST_MODE=true /usr/bin/env bash common/tag.sh
Adding 24 because it might be needed for testing 24-minimal.
Tagged versions are: 24-minimal 24
Error: no such object: "Error: building at STEP \"RUN INSTALL_PKGS=\"nodejs$NODEJS_VERSION nodejs-nodemon nodejs$NODEJS_VERSION-full-i18n nodejs$NODEJS_VERSION-npm findutils tar which\" &&     microdnf -y --nodocs --setopt=install_weak_deps=0 install $INSTALL_PKGS &&     microdnf clean all &&     ln -s /usr/bin/node-$NODEJS_VERSION /usr/bin/node &&     ln -s /usr/bin/npm-$NODEJS_VERSION /usr/bin/npm &&     ln -s /usr/bin/npx-$NODEJS_VERSION /usr/bin/npx &&     node -v | grep -qe \"^v$NODEJS_VERSION\\.\" && echo \"Found VERSION $NODEJS_VERSION\" &&     rm -rf /mnt/rootfs/var/cache/* /mnt/rootfs/var/log/dnf* /mnt/rootfs/var/log/yum.*\": while running runtime: exit status 1"
errexit on line 34, common/tag.sh
errexit on line 34, common/tag.sh
make: *** [common/common.mk:126: tag] Error 125
Shared connection to 10.31.46.173 closed.

@phracek
Copy link
Member

phracek commented Sep 18, 2025

Let's re-run ONLY container tests

[test]

@phracek phracek mentioned this pull request Sep 19, 2025
Closed
@phracek
Copy link
Member

phracek commented Sep 19, 2025

Let's get change to only containers test

[test]

@phracek phracek mentioned this pull request Sep 19, 2025
Merged
@phracek
Copy link
Member

phracek commented Sep 22, 2025

[test]

@phracek
Copy link
Member

phracek commented Sep 22, 2025

[test-openshift][test-openshift-pytest]

@hhorak hhorak changed the title Enable nodejs24 for cXs Enable nodejs24 for cXs and fix RHEL10 Dockerfiles Sep 22, 2025
@hhorak
Copy link
Member Author

hhorak commented Sep 22, 2025

The rate limit issue that makes CI fail might not be resolved for some time, so we agreed with @phracek off-line that it might be better to merge, so we can continue pulling it downstream.

@hhorak hhorak merged commit f70850f into sclorg:master Sep 22, 2025
8 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phracek phracek phracek approved these changes

Assignees

No one assigned

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hhorak @phracek