Add container-pytest to NodeJS Container #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing Farm results
|
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek
force-pushed
the
container_pytests
branch
from
d222188 to
a5302ce
Compare
Signed-off-by: Petr "Stone" Hracek <[email protected]>
The bash tests were migrated to PyTest by following matrix: APP without any -e DEV_MODE or -e NODE_ENV - test_run_app_application -> test_container_apps.py(TestNodeJSAppContainer class) - test_s2i_usage -> test_container_basics.py(TestNodeJSAppContainer class) - test_scl_usage -> test_container_basics.py(TestNodeJSAppContainer class) - test_connection -> test_container_apps.py each Class - test_docker_run_usage -> test_container_basics.py(TestNodeJSAppContainer class) test_container_basics.py(TestNodeJSAppContainer class) - test_npm_functionality - test_check_build_using_dockerfile -> test_container_basics.py(TestNodeJSAppContainer class) - test_nodemon_removed - test_npm_cache_cleared -> test_container_apps.py(TestNodeJSAppContainer class) - test_npm_tmp_cleared -> test_container_apps.py(TestNodeJSAppContainer class) - kill_test_application -> Not needed. Cleanup is done by each test. - test_dev_mode_true_development -> test_container_apps.py(TestNodeJSAppContainer class) - test_dev_mode_false_production -> test_container_apps.py(TestNodeJSAppContainer class) - test_node_cmd_development_init_wrapper_true -> test_container_apps.py(TestNodeJSAppContainer class) - test_node_cmd_production_init_wrapper_true -> test_container_apps.py(TestNodeJSAppContainer class) - test_node_cmd_development_init_wrapper_false -> test_container_apps.py(TestNodeJSAppContainer class) - test_init_wrapper_true_development -> test_container_apps.py(TestNodeJSAppContainer class) - test_init_wrapper_false_development -> test_container_apps.py(TestNodeJSAppContainer class) APP with -e NODE_ENV test_run_app_application -> test_container_apps.py(TestNodeJSAppsWithNodeEnvDevelopmenntContainer class) test_connection -> tested by each test test_nodemon_present -> test_container_apps.py(TestNodeJSAppsWithNodeEnvDevelopmenntContainer class) test_npm_cache_exists -> test_container_apps.py(TestNodeJSAppsWithNodeEnvDevelopmenntContainer class) kill_test_application -> not needed. Cleanup does it by each test test_dev_mode_true_development -> test_container_apps.py(TestNodeJSAppsWithNodeEnvDevelopmenntContainer class) test_dev_mode_false_development -> test_container_apps.py(TestNodeJSAppsWithNodeEnvDevelopmenntContainer class) test_node_cmd_development_init_wrapper_true -> test_container_apps.py(TestNodeJSAppsWithNodeEnvDevelopmenntContainer class) test_node_cmd_production_init_wrapper_true -> test_container_apps.py(TestNodeJSAppsWithNodeEnvDevelopmenntContainer class) test_node_cmd_production_init_wrapper_false -> test_container_apps.py(TestNodeJSAppsWithNodeEnvDevelopmenntContainer class) APP with DEV_MODE test_run_app_application -> test_container_apps(TestNodeJSAppsWithDevModeTrueContainer class) test_connection -> tested by each test by response test_nodemon_present -> test_container_apps(TestNodeJSAppsWithDevModeTrueContainer class) test_npm_cache_exists -> test_container_apps(TestNodeJSAppsWithDevModeTrueContainer class) kill_test_application -> Not needed. It is done by each cleanup test_dev_mode_true_development -> test_container_apps(TestNodeJSAppsWithDevModeTrueContainer class) test_dev_mode_false_production -> test_container_apps(TestNodeJSAppsWithDevModeTrueContainer class) HW tests: - test_safe_logging -> test_container_apps(TestNodeJSAppsHWContainer class) - test_run_hw_application -> test_container_apps(TestNodeJSAppsHWContainer class) - test_incremental_build -> test_container_apps(TestNodeJSAppsHWContainer class) - test_build_express_webapp -> test_container_apps(TestNodeJSAppsHWContainer class) - test_node_cmd_development_init_wrapper_true -> test_container_apps(TestNodeJSAppsHWContainer class) - test_init_wrapper_false_development -> test_container_apps(TestNodeJSAppsHWContainer class) FIPS tests: - test_nodejs_fips_mode -> test_container_basics.py(TestNodeJSFipsContainer class) - test_run_fips_app_application -> test_container_basics.py(TestNodeJSFipsContainer class) Signed-off-by: Petr "Stone" Hracek <[email protected]>
as test.js file Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek
force-pushed
the
container_pytests
branch
from
318cd45 to
803e341
Compare
Signed-off-by: Petr "Stone" Hracek <[email protected]>
they are not tested. Signed-off-by: Petr "Stone" Hracek <[email protected]>
Member
Author
|
Add test-fips to minimal versions. [test-pytest][test-openshift] |
Member
Author
|
RHEL10 failures are mentioned here: #509 |
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Member
Author
|
[test-pytest][test-openshift][test-openshift-pytest] |
Member
Author
|
@frenzymadness PTAL as you will have a bit more time. Thanks. |
Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek
force-pushed
the
container_pytests
branch
from
14eeeb0 to
16ac561
Compare
Member
Author
|
[test-pytest][test-openshift][test-openshift-pytest] |
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Member
Author
|
[test-pytest][test-openshift-pytest] |
Member
Author
|
[test-openshift] |
Member
frenzymadness
left a comment
frenzymadness
left a comment
There was a problem hiding this comment.
Looks good. Just a handful of nitpicks, nothing serious found.
Also remove node_cmd parameter, it is the same for all issues. Add comments to each function so we know what it does. Signed-off-by: Petr "Stone" Hracek <[email protected]>
Member
Author
|
[test-pytest][test-openshift-pytest] |
Member
Author
|
[test] |
Member
Author
|
RHEL10 failures are expected. See issue heree #509 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds PyTest suite for NodeJS Container.
The bash tests were migrated to PyTest by following matrix:
APP without any -e DEV_MODE or -e NODE_ENV
test_container_apps.py(TestNodeJSAppContainer class)
class)
class)
test_container_basics.py(TestNodeJSAppContainer class)
test_container_basics.py(TestNodeJSAppContainer class)
test_container_basics.py(TestNodeJSAppContainer class)
test_container_apps.py(TestNodeJSAppContainer class)
class)
class)
class)
class)
class)
class)
class)
class)
APP with -e NODE_ENV
class)
class)
class)
class)
class)
class)
class)
class)
APP with DEV_MODE
HW tests:
test_container_apps(TestNodeJSAppsHWContainer class)
test_container_apps(TestNodeJSAppsHWContainer class)
test_container_apps(TestNodeJSAppsHWContainer class)
test_container_apps(TestNodeJSAppsHWContainer class)
test_container_apps(TestNodeJSAppsHWContainer class)
test_container_apps(TestNodeJSAppsHWContainer class)
FIPS tests:
test_container_basics.py(TestNodeJSFipsContainer class)
test_container_basics.py(TestNodeJSFipsContainer class)