Skip to content

Allow NPM_TOKEN for downloading package from private repositories. #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
phracek merged 1 commit into from
Jan 20, 2026
Merged

Allow NPM_TOKEN for downloading package from private repositories. #524

phracek merged 1 commit into from
Jan 20, 2026

Conversation

@phracek
Copy link
Member

@phracek phracek commented Jan 19, 2026 •
edited by github-actions bot
Loading

Add support NPM_TOKEN for successfully downloading

npm packages from private NPM repositories.

The pull request also contains test suite as for
BASH as for PyThon.

See Jira issue: https://issues.redhat.com/browse/RHEL-113826

@phracek
Copy link
Member Author

phracek commented Jan 19, 2026

[test][test-pytest]

@phracek phracek requested review from hhorak and khardix January 19, 2026 13:09
@phracek phracek requested a review from pkhartsk January 19, 2026 13:10
@github-actions
Copy link

github-actions bot commented Jan 19, 2026 •
edited
Loading

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
CentOS Stream 10 - 22CentOS-Stream-10x86_64✅ passed20.01.2026 06:57:0712min 24stest pipeline
CentOS Stream 9 - PyTest - 24CentOS-Stream-9x86_64✅ passed20.01.2026 06:50:5117min 33stest pipeline
RHEL9 - FIPS Enabled - 24RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 06:30:3425min 18stest pipeline
Fedora - PyTest - 20Fedora-latestx86_64✅ passed19.01.2026 16:34:0216min 38stest pipeline
RHEL10 - FIPS Enabled - 24-minimalRHEL-10-Nightlyx86_64✅ passed19.01.2026 13:10:082h 30min 3stest pipeline
RHEL10 - FIPS Enabled - 22-minimalRHEL-10-Nightlyx86_64✅ passed19.01.2026 16:34:011h 11min 47stest pipeline
RHEL10 - PyTest - 24RHEL-10-Nightlyx86_64✅ passed20.01.2026 07:49:3419min 43stest pipeline
RHEL10 - FIPS Enabled - 24RHEL-10-Nightlyx86_64✅ passed19.01.2026 16:34:011h 15min 13stest pipeline
RHEL9 - FIPS Enabled - 24-minimalRHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 06:30:3423min 49stest pipeline
RHEL9 - FIPS Enabled - 20-minimalRHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 06:30:3423min 52stest pipeline
RHEL9 - FIPS Enabled - 22-minimalRHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 06:30:3224min 41stest pipeline
RHEL9 - FIPS Enabled - 22RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 06:30:3326min 3stest pipeline
Fedora - 24Fedora-latestx86_64✅ passed20.01.2026 07:11:189min 41stest pipeline
RHEL9 - FIPS Enabled - 20RHEL-9.6.0-Nightlyx86_64✅ passed19.01.2026 13:10:072h 41min 17stest pipeline
CentOS Stream 9 - PyTest - 24-minimalCentOS-Stream-9x86_64✅ passed19.01.2026 17:08:5331min 15stest pipeline
CentOS Stream 10 - PyTest - 22CentOS-Stream-10x86_64✅ passed20.01.2026 06:55:0115min 34stest pipeline
RHEL10 - Unsubscribed host - PyTest - 24-minimalRHEL-10-Nightlyx86_64✅ passed19.01.2026 16:34:101h 13min 8stest pipeline
Fedora - 20Fedora-latestx86_64✅ passed20.01.2026 07:21:309min 49stest pipeline
Fedora - PyTest - 24-minimalFedora-latestx86_64✅ passed20.01.2026 07:07:2011min 19stest pipeline
Fedora - 24-minimalFedora-latestx86_64✅ passed19.01.2026 16:34:146min 43stest pipeline
CentOS Stream 9 - 24-minimalCentOS-Stream-9x86_64✅ passed19.01.2026 16:34:1212min 40stest pipeline
CentOS Stream 10 - 24CentOS-Stream-10x86_64✅ passed19.01.2026 16:34:2612min 26stest pipeline
Fedora - PyTest - 20-minimalFedora-latestx86_64✅ passed19.01.2026 16:34:0314min 32stest pipeline
CentOS Stream 10 - 22-minimalCentOS-Stream-10x86_64✅ passed19.01.2026 16:42:349min 52stest pipeline
Fedora - 20-minimalFedora-latestx86_64✅ passed19.01.2026 16:48:487min 51stest pipeline
CentOS Stream 9 - 24CentOS-Stream-9x86_64✅ passed19.01.2026 16:52:2615min 59stest pipeline
RHEL10 - FIPS Enabled - 22RHEL-10-Nightlyx86_64✅ passed19.01.2026 16:34:031h 13min 16stest pipeline
RHEL9 - Unsubscribed host - PyTest - 22-minimalRHEL-9.6.0-Nightlyx86_64✅ passed19.01.2026 16:34:091h 12min 44stest pipeline
RHEL8 - PyTest - 20RHEL-8.10.0-Nightlyx86_64✅ passed19.01.2026 16:34:021h 15min 56stest pipeline
Fedora - 22-minimalFedora-latestx86_64✅ passed20.01.2026 06:30:337min 37stest pipeline
Fedora - 22Fedora-latestx86_64✅ passed20.01.2026 06:30:359min 29stest pipeline
RHEL10 - Unsubscribed host - 22-minimalRHEL-10-Nightlyx86_64✅ passed20.01.2026 06:30:3313min 3stest pipeline
Fedora - PyTest - 22-minimalFedora-latestx86_64✅ passed20.01.2026 06:30:3412min 24stest pipeline
CentOS Stream 9 - PyTest - 20CentOS-Stream-9x86_64✅ passed20.01.2026 06:30:3517min 10stest pipeline
RHEL9 - Unsubscribed host - 22-minimalRHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 06:30:3517min 43stest pipeline
RHEL9 - Unsubscribed host - 24-minimalRHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 06:30:3319min test pipeline
RHEL10 - Unsubscribed host - PyTest - 22RHEL-10-Nightlyx86_64✅ passed20.01.2026 06:30:3319min 37stest pipeline
RHEL10 - Unsubscribed host - PyTest - 24RHEL-10-Nightlyx86_64✅ passed20.01.2026 06:30:3519min 15stest pipeline
RHEL9 - 24RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 06:30:3421min 56stest pipeline
RHEL9 - 20RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 06:30:3521min 8stest pipeline
RHEL9 - PyTest - 22RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 06:30:3425min 59stest pipeline
RHEL8 - 20-minimalRHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 06:41:0115min 41stest pipeline
RHEL10 - 24-minimalRHEL-10-Nightlyx86_64✅ passed20.01.2026 06:44:5513min 30stest pipeline
RHEL9 - Unsubscribed host - 22RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 06:38:5819min 36stest pipeline
CentOS Stream 9 - 20CentOS-Stream-9x86_64✅ passed20.01.2026 06:50:5712min 8stest pipeline
Fedora - PyTest - 24Fedora-latestx86_64✅ passed20.01.2026 06:50:4714min 5stest pipeline
RHEL8 - 22RHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 06:48:5616min 29stest pipeline
RHEL8 - PyTest - 22-minimalRHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 06:44:5920min 27stest pipeline
RHEL9 - Unsubscribed host - PyTest - 24-minimalRHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 06:48:5617min 34stest pipeline
RHEL8 - PyTest - 22RHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 06:48:5820min 56stest pipeline
RHEL10 - Unsubscribed host - 24-minimalRHEL-10-Nightlyx86_64✅ passed20.01.2026 06:56:5113min 9stest pipeline
RHEL8 - 22-minimalRHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 06:54:5417min 7stest pipeline
RHEL10 - 22RHEL-10-Nightlyx86_64✅ passed20.01.2026 06:56:5915min 39stest pipeline
RHEL10 - 24RHEL-10-Nightlyx86_64✅ passed20.01.2026 06:57:2215min 23stest pipeline
RHEL9 - PyTest - 20-minimalRHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 06:52:5823min 34stest pipeline
RHEL10 - PyTest - 22RHEL-10-Nightlyx86_64✅ passed20.01.2026 06:56:5120min 37stest pipeline
CentOS Stream 10 - 24-minimalCentOS-Stream-10x86_64✅ passed20.01.2026 07:07:1111min 10stest pipeline
RHEL9 - Unsubscribed host - 24RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 06:59:1719min 22stest pipeline
RHEL9 - 24-minimalRHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 06:59:1919min 35stest pipeline
RHEL10 - Unsubscribed host - 24RHEL-10-Nightlyx86_64✅ passed20.01.2026 07:49:3216min 15stest pipeline
CentOS Stream 9 - 20-minimalCentOS-Stream-9x86_64✅ passed20.01.2026 07:09:1311min 3stest pipeline
RHEL9 - PyTest - 20RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 06:56:5924min 41stest pipeline
RHEL9 - Unsubscribed host - 20-minimalRHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 07:07:1818min test pipeline
RHEL9 - Unsubscribed host - PyTest - 24RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 07:07:1619min 41stest pipeline
CentOS Stream 10 - PyTest - 24-minimalCentOS-Stream-10x86_64✅ passed20.01.2026 07:13:1715min 21stest pipeline
CentOS Stream 10 - PyTest - 24CentOS-Stream-10x86_64✅ passed20.01.2026 07:11:3617min 3stest pipeline
Fedora - PyTest - 22Fedora-latestx86_64✅ passed20.01.2026 07:13:3914min 14stest pipeline
RHEL9 - Unsubscribed host - 20RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 07:11:1519min 56stest pipeline
RHEL9 - 20-minimalRHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 07:11:2719min 45stest pipeline
CentOS Stream 10 - PyTest - 22-minimalCentOS-Stream-10x86_64✅ passed20.01.2026 07:19:1614min 11stest pipeline
RHEL9 - 22-minimalRHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 07:13:1820min 25stest pipeline
RHEL10 - 22-minimalRHEL-10-Nightlyx86_64✅ passed20.01.2026 07:19:4214min 41stest pipeline
RHEL10 - PyTest - 22-minimalRHEL-10-Nightlyx86_64✅ passed20.01.2026 07:17:2418min 49stest pipeline
RHEL10 - Unsubscribed host - 22RHEL-10-Nightlyx86_64✅ passed20.01.2026 07:23:2514min 54stest pipeline
RHEL10 - PyTest - 24-minimalRHEL-10-Nightlyx86_64✅ passed20.01.2026 07:19:3418min 11stest pipeline
RHEL9 - PyTest - 22-minimalRHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 07:13:4225min 2stest pipeline
RHEL9 - 22RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 07:19:3521min 10stest pipeline
RHEL9 - Unsubscribed host - PyTest - 22RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 07:21:3719min 42stest pipeline
RHEL9 - PyTest - 24-minimalRHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 07:19:3224min 55stest pipeline
RHEL9 - PyTest - 24RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 07:19:5225min 24stest pipeline

@pkhartsk
Copy link
Contributor

pkhartsk commented Jan 19, 2026

Are all the pytests commented out only temporarily?

@phracek phracek force-pushed the support_npm_authentication branch from fdd4505 to 0d9ce4d Compare January 19, 2026 16:30
@phracek
Add support NPM_TOKEN for successfully downloading
fe8e844 
npm packages from private NPM repositories.

The pull request also contains test suite as for
BASH as for PyThon.

See Jira issue: https://issues.redhat.com/browse/RHEL-113826

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek phracek force-pushed the support_npm_authentication branch from 0d9ce4d to fe8e844 Compare January 19, 2026 16:32
@phracek
Copy link
Member Author

phracek commented Jan 19, 2026

[test][test-pytest]

@phracek
Copy link
Member Author

phracek commented Jan 19, 2026

Are all the pytests commented out only temporarily?

Error from my side during debugging. Fixed.

pkhartsk
pkhartsk approved these changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@pkhartsk pkhartsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phracek phracek merged commit 9076c49 into sclorg:master Jan 20, 2026
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khardix khardix khardix approved these changes

@pkhartsk pkhartsk pkhartsk approved these changes

@hhorak hhorak Awaiting requested review from hhorak

Assignees

No one assigned

Labels

enhancement P1 ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phracek @pkhartsk @khardix