Abstracted Common models

[geoffgifford01]

Hi,
There are multiple opportunities to create commonality between ibsync and ibapi.
Is there an appetite to separate out the common models - like ContractDetails, Contract, Connection etc. into their own library/git.
This would make using both ibsync and ibapi together in the same app substantially cleaner.
For example, I have a use case where streaming into the ticker object is not quite suitable, and it would be great I could simply reach into ibapi for some of the streaming with common models.
(I realise I could use an interface for casting). This was just a thought...

[pchavanne]

Hi Geoff,

This an interesting point.
Can't you use ibapi as the client and import the desired structs from ibsync for your own implementation?

[geoffgifford01]

Yes - I could do that.
I could also do something like:

`
// Contract interface defines common behavior
type Contract interface {
GetSymbol() string
GetExchange() string
GetCurrency() string
GetSecType() string
GetExpiry() string
}

// Implement for ibsync.Contract
func (c ibsync.Contract) GetSymbol() string { return c.Symbol }
func (c ibsync.Contract) GetExchange() string { return c.PrimaryExchange }
func (c ibsync.Contract) GetCurrency() string { return c.Currency }
func (c ibsync.Contract) GetSecType() string { return c.SecType }
func (c ibsync.Contract) GetExpiry() string { return c.LastTradeDateOrContractMonth }

// Implement for ibapi.Contract
func (c ibapi.Contract) GetSymbol() string { return c.Symbol }
func (c ibapi.Contract) GetExchange() string { return c.Exchange }
func (c ibapi.Contract) GetCurrency() string { return c.Currency }
func (c ibapi.Contract) GetSecType() string { return c.SecurityType }
func (c ibapi.Contract) GetExpiry() string { return c.Expiry }
`

I was simply thinking that if the common models were abstracted that would make it easier to share the libs and perhaps make maintenance easier.

It was really more a "musing" than an actual request (and I'm a golang hobbyist, so probably don't know what I'm talking about).

[geoffgifford01]

My use case was to complete a search in ibsync, and then use the ContractDetails from the selected search item in a call to streaming with ibapi.

Still both excellent libraries and I love your work. Thanks

[pchavanne]

Thank you very much for your kind words. Much appreciated.
I am happy that you like the code .