Discussion for future of MySQL/MariaDB plugins

[scottchiefbaker]

Up until recently the MySQL/MariaDB plugins didn't work at all. Thank you goes out to @btriller for getting them working on modern Python/Dool. As we move forward I think it's worth having a discussion about what we want from these plugins. I have a couple of design concerns:

1. We have mysql_io and mysql5_io. Is there a need to have the MySQL version number 5 in the plugin?
2. We have two plugins that are symlinks to dool_mysql5_innodb.py... why?
3. We have dool_mysql5_io.py and dool_mysql_io.py
   1. The first uses MySQLdb and the second uses the mysql cli binary.
   2. Do we need them both? Which is better?
4. Are we testing these against MariaDB also? They should "Just Work (tm)" but I want to double check.

Just want to clarify that I'm not criticizing any past code that was written. As we're looking at these plugins it's probably a good time to take a holistic look at all of them and come up with a cohesive strategy moving forward.

[scottchiefbaker]

FYI MySQL 5.x was released in 2008. I can't think of any reason why we need to include any "number" in the plugin name.

[scottchiefbaker]

I made the executive decision to retire the MySQL CLI binary plugins in favor of using MySQLdb instead because it's more efficient.

I also renamed all of the mysql5 plugins to mysql

Looking at the InnoDB plugins they used filename "magic" to determine what mode to run in, hence the symlinks. I deleted the symlinks and changed to using an env var instead

I tested against my MariaDB server and things seemed to work fine.

I'm debating changing the name of mysql-cmds to mysql as it seems like what most people would want as a way to monitor a DB server.