Add S1D to SentinelOrbit regex to avoid error in RESORB download (#75)

* Add `S1D` to `SentinelOrbit` regex to avoid error in RESORB download

ASF currently has a test S1D orbit file in the S3 bucket.
This causes the RESORB search to error.

Closes #74

* typo

Author: scottstanie

eof/products.py

@@ -123,7 +123,7 @@ class Sentinel(Base):
     """
 
     FILE_REGEX = re.compile(
-        r"(?P<mission>S1A|S1B|S1C)_"
+        r"(?P<mission>S1A|S1B|S1C|S1D|S1E)_"
         r"(?P<beam>[\w\d]{2})_"
         r"(?P<product_type>[\w_]{3})"
         r"(?P<resolution_class>[FHM_])_"
@@ -250,6 +250,8 @@ def relative_orbit(self):
             return ((self.absolute_orbit - 27) % 175) + 1
         elif self.mission == "S1C":
             return ((self.absolute_orbit - 172) % 175) + 1
+        else:
+            raise ValueError(f"Unknown relative orbit for mission {self.mission}")
 
     @property
     def path(self):
@@ -305,7 +307,7 @@ class SentinelOrbit(Base):
 
     TIME_FMT = "%Y%m%dT%H%M%S"
     FILE_REGEX = (
-        r"(?P<mission>S1A|S1B|S1C)_OPER_AUX_"
+        r"(?P<mission>S1A|S1B|S1C|S1D|S1E)_OPER_AUX_"
         r"(?P<orbit_type>[\w_]{6})_OPOD_"
         r"(?P<created_datetime>[T\d]{15})_"
         r"V(?P<start_datetime>[T\d]{15})_"

eof/tests/test_eof.py

@@ -16,19 +16,22 @@ def test_find_scenes_to_download(tmpdir):
             "S1B_IW_SLC__1SDV_20180502T043026_20180502T043054_021721_025793_5C18.zip"
         )
         name3 = "S1C_IW_SLC__1SDV_20250331T060116_20250331T060143_001681_002CD0_8D44"
+        # Fake S1D name
+        name4 = "S1D_IW_SLC__1SDV_20250731T060116_20250731T060143_001681_002CD0_8D44"
         open(name1, "w").close()
         open(name2, "w").close()
         open(name3, "w").close()
+        open(name4, "w").close()
         orbit_dates, missions = download.find_scenes_to_download(search_path=".")
 
+        # S1D ignored for now
+        assert sorted(missions) == ["S1A", "S1B", "S1C"]
         assert sorted(orbit_dates) == [
             datetime.datetime(2018, 4, 20, 4, 30, 26),
             datetime.datetime(2018, 5, 2, 4, 30, 26),
             datetime.datetime(2025, 3, 31, 6, 1, 16),
         ]
 
-        assert sorted(missions) == ["S1A", "S1B", "S1C"]
-
 
 @pytest.mark.vcr
 def test_download_eofs_errors():

eof/tests/test_products.py

@@ -62,3 +62,16 @@ def test_s1c():
     assert p.relative_orbit == 110
     assert p.polarization == "DV"
     assert p.mission == "S1C"
+
+
+def test_s1d_fake_orbit_issue_74():
+    """Tests ability to handle S1D: https://github.com/scottstanie/sentineleof/issues/74 ."""
+    fname = (
+        "S1D_OPER_AUX_RESORB_OPOD_20250703T092541_V20250703T045039_20250703T080809.EOF"
+    )
+    p = SentinelOrbit(fname)
+
+    assert p.filename == fname
+    assert p.start_time == datetime(2025, 7, 3, 4, 50, 39)
+    assert p.stop_time == datetime(2025, 7, 3, 8, 8, 9)
+    assert p.mission == "S1D"