From 0e838fa0dc798945f5a818fb2ac8e367231fcb1d Mon Sep 17 00:00:00 2001 From: Jason Champion Date: Wed, 31 Mar 2021 18:30:06 -0700 Subject: [PATCH] Add timeout parameter to requests calls because they can hang forever if the connection does not close properly. --- src/favicon/favicon.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/favicon/favicon.py b/src/favicon/favicon.py index 5730f91..b339278 100644 --- a/src/favicon/favicon.py +++ b/src/favicon/favicon.py @@ -62,7 +62,7 @@ def get(url, *args, **request_kwargs): request_kwargs.setdefault('headers', HEADERS) request_kwargs.setdefault('allow_redirects', True) - response = requests.get(url, **request_kwargs) + response = requests.get(url, timeout=20, **request_kwargs) response.raise_for_status() icons = set() @@ -92,7 +92,7 @@ def default(url, **request_kwargs): """ parsed = urlparse(url) favicon_url = urlunparse((parsed.scheme, parsed.netloc, 'favicon.ico', '', '', '')) - response = requests.head(favicon_url, **request_kwargs) + response = requests.head(favicon_url, timeout=20, **request_kwargs) if response.status_code == 200: return Icon(response.url, 0, 0, 'ico')