Skip to content

Commit 9c1ecfe

Browse files
authored
Build fixes and docs link (#793)
* fix pre-commit check-manifest missing dependencies * update docs url * add missing setuptool dependency for github workflow * provide unique basemane for drf router viewsets
1 parent 8da327b commit 9c1ecfe

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

.github/workflows/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ jobs:
5555
with:
5656
python-version: ${{ matrix.python-version }}
5757
- name: Upgrade packaging tools
58-
run: python -m pip install --upgrade pip setuptools virtualenv
58+
run: python -m pip install --upgrade pip setuptools importlib_metadata virtualenv
5959
- name: Install dependencies
6060
run: python -m pip install --upgrade tox
6161
- name: Run tox targets for ${{ matrix.python-version }}
@@ -104,7 +104,7 @@ jobs:
104104
with:
105105
python-version: ${{ matrix.python-version }}
106106
- name: Upgrade packaging tools
107-
run: python -m pip install --upgrade pip setuptools virtualenv
107+
run: python -m pip install --upgrade pip setuptools importlib_metadata virtualenv
108108
- name: Install dependencies
109109
run: python -m pip install --upgrade tox
110110
- name: Run tox targets for ${{ matrix.python-version }}

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ jobs:
9191
python-version: ${{ matrix.python-version }}
9292
- name: Install packaging tools
9393
run: |
94-
python -m pip install --upgrade pip setuptools wheel
94+
python -m pip install --upgrade pip setuptools importlib_metadata wheel
9595
9696
- name: Build Python pure Python wheel
9797
env:

.pre-commit-config.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,3 +42,4 @@ repos:
4242
hooks:
4343
- id: check-manifest
4444
args: [--no-build-isolation]
45+
additional_dependencies: [setuptools, wheel, setuptools-scm]

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ To use Scout, you'll need to
3535

3636
For full installation instructions, including information on configuring Scout
3737
via environment variables and troubleshooting, see our
38-
[Python docs](https://docs.scoutapm.com/#python-agent).
38+
[Python docs](https://scoutapm.com/docs/python).
3939

4040
## Support
4141

tests/integration/django_app.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,8 @@ def get_queryset(self, *args, **kwargs):
193193
raise ValueError("BØØM!")
194194

195195
router = routers.SimpleRouter()
196-
router.register(r"users", UserViewSet)
197-
router.register(r"crash", ErrorViewSet)
196+
router.register(r"users", UserViewSet, basename="user")
197+
router.register(r"crash", ErrorViewSet, basename="error")
198198

199199
return router
200200

0 commit comments

Comments
 (0)