Skip to content

Commit ca676e1

Browse files
authored
Cleanup ignore warnings (#89)
* Remove unused imports * Do not use deprecated ignore_warnings
1 parent a731b96 commit ca676e1

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

sh_scrapy/crawl.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,14 +169,14 @@ def _run_script(dist, script_name, namespace):
169169
exec(code, namespace, namespace)
170170

171171

172-
173172
def _run_usercode(spider, args, apisettings_func,
174173
log_handler=None, commands_module=None):
175174
try:
176175
from scrapy.exceptions import ScrapyDeprecationWarning
177176
from sh_scrapy.settings import populate_settings
178177

179-
with ignore_warnings(category=ScrapyDeprecationWarning):
178+
with warnings.catch_warnings():
179+
warnings.filterwarnings("ignore", category=ScrapyDeprecationWarning)
180180
settings = populate_settings(apisettings_func(), spider)
181181
if commands_module:
182182
settings.set('COMMANDS_MODULE', commands_module, priority=40)

sh_scrapy/extension.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,11 @@
66
import scrapy
77
from scrapy import signals
88
from scrapy import version_info as SCRAPY_VERSION_INFO
9-
from scrapy.exceptions import ScrapyDeprecationWarning
109
from scrapy.exporters import PythonItemExporter
1110
from scrapy.http import Request
1211
from scrapy.utils.deprecate import create_deprecated_class
1312

1413
from sh_scrapy import hsref
15-
from sh_scrapy.crawl import ignore_warnings
1614
from sh_scrapy.exceptions import SHScrapyDeprecationWarning
1715
from sh_scrapy.middlewares import HS_PARENT_ID_KEY, request_id_sequence
1816
from sh_scrapy.writer import pipe_writer

0 commit comments

Comments
 (0)