[tests] add tests for cmdline

Author: pawelmhm

tests/__init__.py

@@ -3,3 +3,4 @@
 
 TESTS_PATH = os.path.realpath(os.path.dirname(__file__))
 PROJECT_PATH = os.path.realpath(os.path.join(TESTS_PATH, '..'))
+SAMPLE_DATA = os.path.join(TESTS_PATH, 'sample_data')

tests/servers.py

@@ -12,11 +12,10 @@
 import port_for
 
 from scrapyrt.utils import is_python2
-from . import TESTS_PATH
-from .utils import get_testenv
+from . import SAMPLE_DATA
+from .utils import get_testenv, generate_project
 
 DEVNULL = open(os.devnull, 'wb')
-SAMPLE_DATA = os.path.join(TESTS_PATH, 'sample_data')
 
 
 class BaseTestServer(object):
@@ -116,20 +115,7 @@ def __init__(self, site=None, *args, **kwargs):
         self.stderr = PIPE
         self.tmp_dir = tempfile.mkdtemp()
         self.cwd = os.path.join(self.tmp_dir, 'testproject')
-
-        source = os.path.join(SAMPLE_DATA, 'testproject')
-        shutil.copytree(
-            source, self.cwd, ignore=shutil.ignore_patterns('*.pyc'))
-        # Pass site url to spider doing start requests
-        spider_name = "testspider_startrequests.py"
-        spider_filename = os.path.join(self.cwd, "testproject", "spider_templates", spider_name)
-        spider_target_place = os.path.join(self.cwd, "testproject", "spiders", spider_name)
-        if not site:
-            return
-        with open(spider_filename) as spider_file:
-            spider_string = spider_file.read().format(site.url("page1.html"), site.url("page2.html"))
-            with open(spider_target_place, "wb") as file_target:
-                file_target.write(spider_string.encode('utf8'))
+        generate_project(self.cwd, site=site)
 
     def stop(self):
         super(ScrapyrtTestServer, self).stop()

tests/test_cmdline.py

@@ -0,0 +1,55 @@
+import pytest
+import sys
+import tempfile
+from collections import namedtuple
+from os import path, chdir
+from scrapy.utils.conf import closest_scrapy_cfg
+from twisted.python.components import Componentized
+
+from scrapyrt.cmdline import find_scrapy_project, get_application
+from tests.utils import generate_project
+
+
+def make_fake_args():
+    fake_args = namedtuple('arguments', [
+        'port',
+        'ip',
+        'set',
+        'project',
+        'settings'
+    ])
+    return fake_args(
+        9080,
+        '0.0.0.0',
+        [],
+        'default',
+        ''
+    )
+
+
+@pytest.fixture
+def workdir():
+    tmp_dir = tempfile.mkdtemp()
+    workdir = path.join(tmp_dir, 'testproject')
+    generate_project(workdir)
+    chdir(workdir)
+    return workdir
+
+
+class TestCmdLine(object):
+    def test_find_scrapy_project(self, workdir):
+        settings = find_scrapy_project('default')
+        assert 'testproject.settings' == settings
+        assert workdir in sys.path
+
+    def test_find_scrapy_project_invalid_conf(self, workdir):
+        config = closest_scrapy_cfg()
+        with open(config, 'wb') as f:
+            f.write(b'[other_section]')
+        with pytest.raises(RuntimeError) as err:
+            find_scrapy_project('default')
+        assert str(err.value) == "No section: 'settings'"
+
+    def test_get_application(self):
+        app = get_application(make_fake_args())
+        assert isinstance(app, Componentized)

tests/utils.py

@@ -1,10 +1,10 @@
 # -*- coding: utf-8 -*-
 import os
-import socket
 
+import shutil
 from scrapy.settings import Settings
 
-from . import TESTS_PATH
+from . import TESTS_PATH, SAMPLE_DATA
 
 LOCALHOST = 'localhost'
 
@@ -30,3 +30,19 @@ def get_settings():
             'scrapy.extensions.telnet.TelnetConsole': None,
         }
     })
+
+
+def generate_project(directory, site=None):
+    source = os.path.join(SAMPLE_DATA, 'testproject')
+    shutil.copytree(
+        source, directory, ignore=shutil.ignore_patterns('*.pyc'))
+    # Pass site url to spider doing start requests
+    spider_name = "testspider_startrequests.py"
+    spider_filename = os.path.join(directory, "testproject", "spider_templates", spider_name)
+    spider_target_place = os.path.join(directory, "testproject", "spiders", spider_name)
+    if not site:
+        return
+    with open(spider_filename) as spider_file:
+        spider_string = spider_file.read().format(site.url("page1.html"), site.url("page2.html"))
+        with open(spider_target_place, "wb") as file_target:
+            file_target.write(spider_string.encode('utf8'))