Skip to content

Commit e5d83bf

Browse files
committed
[tests] fix warnings about deprecated or bad test code
1 parent dc24afe commit e5d83bf

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

tests/test_crawl_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ def setUp(self):
334334

335335
def test_return_items(self):
336336
result = self.crawl_manager.return_items(None)
337-
self.assertDictContainsSubset(self.expected_result, result)
337+
self.assertEqual(dict(result, **self.expected_result), result)
338338
self.assertEqual(list(sorted(self.stats.keys())), list(result['stats'].keys()))
339339
# debug = True by default
340340
self.assertIn('errors', result)

tests/test_resource_realtimeapi.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from scrapyrt.resources import RealtimeApi, ServiceResource, CrawlResource
1010

1111

12-
class TestResource(ServiceResource):
12+
class SampleResource(ServiceResource):
1313
isLeaf = True
1414
allowedMethods = ['GET', 'POST']
1515

@@ -35,10 +35,10 @@ def test_realtimeapi_with_default_settings(self):
3535
@patch('scrapyrt.resources.settings', deepcopy(settings))
3636
def test_realtimeapi_with_custom_settings(self):
3737
from scrapyrt.resources import settings
38-
settings.RESOURCES[b'test.json'] = self._get_class_path('TestResource')
38+
settings.RESOURCES[b'test.json'] = self._get_class_path('SampleResource')
3939
expected_entities = {
4040
b'crawl.json': CrawlResource,
41-
b'test.json': TestResource
41+
b'test.json': SampleResource
4242
}
4343
service_root = RealtimeApi()
4444
self._check_entities(service_root, expected_entities)

0 commit comments

Comments
 (0)