Skip to content

Commit 0010575

Browse files
committed
Revert "allow render_all in chromium engine"
This reverts commit 2863396.
1 parent 4809cb3 commit 0010575

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

splash/engines/chromium/browser_tab.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -145,8 +145,8 @@ def png(self, width=None, height=None, b64=False, render_all=False,
145145
"Getting PNG: width=%s, height=%s, "
146146
"render_all=%s, scale_method=%s, region=%s" %
147147
(width, height, render_all, scale_method, region), min_level=2)
148-
# if render_all:
149-
# raise ValueError("render_all=True is not supported yet")
148+
if render_all:
149+
raise ValueError("render_all=True is not supported yet")
150150

151151
image = self._get_image('PNG', width, height, render_all,
152152
scale_method, region=region)
@@ -165,8 +165,8 @@ def jpeg(self, width=None, height=None, b64=False, render_all=False,
165165
"render_all=%s, scale_method=%s, quality=%s, region=%s" %
166166
(width, height, render_all, scale_method, quality, region),
167167
min_level=2)
168-
# if render_all:
169-
# raise ValueError("render_all=True is not supported yet")
168+
if render_all:
169+
raise ValueError("render_all=True is not supported yet")
170170

171171
image = self._get_image('JPEG', width, height, render_all,
172172
scale_method, region=region)
@@ -178,10 +178,6 @@ def jpeg(self, width=None, height=None, b64=False, render_all=False,
178178

179179
def _get_image(self, image_format, width, height, render_all,
180180
scale_method, region):
181-
if render_all:
182-
self.logger.log("Rendering whole page contents (RENDER_ALL)",
183-
min_level=2)
184-
self.set_viewport('full')
185181
renderer = QtChromiumScreenshotRenderer(
186182
self.web_page, self.logger, image_format,
187183
width=width, height=height, scale_method=scale_method,

0 commit comments

Comments
 (0)