Skip to content

Commit f23a045

Browse files
committed
Update default download handler invocation
1 parent 99c369f commit f23a045

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

scrapy_playwright/handler.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,9 @@
5252
__all__ = ["ScrapyPlaywrightDownloadHandler"]
5353

5454

55+
_SCRAPY_ASYNC_API = scrapy_version_info >= (2, 14, 0)
56+
57+
5558
PlaywrightHandler = TypeVar("PlaywrightHandler", bound="ScrapyPlaywrightDownloadHandler")
5659

5760

@@ -138,7 +141,7 @@ class ScrapyPlaywrightDownloadHandler(HTTP11DownloadHandler):
138141
playwright: Optional[AsyncPlaywright] = None
139142

140143
def __init__(self, crawler: Crawler) -> None:
141-
if scrapy_version_info >= (2, 14, 0):
144+
if _SCRAPY_ASYNC_API:
142145
super().__init__(crawler=crawler) # pylint: disable=no-value-for-parameter
143146
else:
144147
super().__init__(settings=crawler.settings, crawler=crawler)
@@ -374,6 +377,8 @@ async def _close(self) -> None:
374377
def download_request(self, request: Request, spider: Spider) -> Deferred:
375378
if request.meta.get("playwright"):
376379
return self._deferred_from_coro(self._download_request(request, spider))
380+
if _SCRAPY_ASYNC_API:
381+
return super().download_request(request)
377382
return super().download_request(request, spider)
378383

379384
async def _download_request(self, request: Request, spider: Spider) -> Response:

0 commit comments

Comments
 (0)