using getbool and getlist to get the values from spider.settings

Author: gabrielweiz

src/scrapy_settings_log/__init__.py

@@ -51,13 +51,13 @@ def spider_closed(self, spider):
         regex = settings.get("SETTINGS_LOGGING_REGEX")
         if regex is not None:
             settings = {k: v for k, v in settings.items() if re.search(regex, k)}
-        if settings.get("MASKED_SENSITIVE_SETTINGS_ENABLED", True):
+        if spider.settings.getbool("MASKED_SENSITIVE_SETTINGS_ENABLED", True):
             default_regexes = [
                 ".*(?i)(api[\W_]*key).*",  # apikey and possible variations e.g: shub_apikey or SC_APIKEY
                 ".*(?i)(AWS[\W_]*SECRET[\W_]*ACCESS[\W_]*KEY).*",  # AWS_SECRET_ACCESS_KEY and possible variations
                 ".*(?i)([\W_]*password[\W_]*).*"  # password word
             ]
-            regex_list = settings.get("MASKED_SENSITIVE_SETTINGS_REGEX_LIST", default_regexes)
+            regex_list = spider.settings.getlist("MASKED_SENSITIVE_SETTINGS_REGEX_LIST", default_regexes)
             for reg in regex_list:
                 updated_settings = {k: '**********' if v else v for k, v in settings.items() if re.match(reg, k)}
                 settings = {**settings, **updated_settings}