Skip to content

Commit 03aaab9

Browse files
committed
Rename dont_proxy to dont_splash and document it
1 parent ed2ca00 commit 03aaab9

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

README.rst

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,9 @@ using a ``splash`` spider attribute::
172172
}
173173

174174
If you use a ``splash`` spider attribute, you can still override those Splash
175-
settings for specific requests using the ``splash`` request meta key.
175+
settings for specific requests using the ``splash`` request meta key, or
176+
disable Splash completely setting the ``dont_splash`` request meta key to
177+
``True``.
176178

177179
Use ``request.meta['splash']`` API in middlewares or when scrapy.Request
178180
subclasses are used (there is also ``SplashFormRequest`` described below).

scrapy_splash/middleware.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ def _remote_keys(self):
258258
return self.crawler.spider.state[self.remote_keys_key]
259259

260260
def _get_splash_options(self, request, spider):
261-
if request.meta.get("dont_proxy"):
261+
if request.meta.get("dont_splash") is True:
262262
return
263263
spider_options = getattr(spider, "splash", {})
264264
request_options = request.meta.get("splash")

0 commit comments

Comments
 (0)