Skip to content

Commit 2c93743

Browse files
committed
Clean up
1 parent cb2d418 commit 2c93743

File tree

3 files changed

+4
-20
lines changed

3 files changed

+4
-20
lines changed

scrapy_zyte_api/_middlewares.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def slot_request(
4444
f"deprecated and the argument will be removed in a future "
4545
f"scrapy-zyte-api version.",
4646
category=ScrapyDeprecationWarning,
47-
stacklevel=1,
47+
stacklevel=2,
4848
)
4949

5050
if not force and self._param_parser.parse(request) is None:

scrapy_zyte_api/handler.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ async def _download_request(
291291
try:
292292
api_response = await self._session.get(api_params, retrying=retrying)
293293
except RequestError as error:
294-
await self._process_request_error(request, error)
294+
self._process_request_error(request, error)
295295
raise
296296
except Exception as er:
297297
logger.debug(
@@ -325,7 +325,7 @@ async def _download_request(
325325

326326
return response
327327

328-
async def _process_request_error(self, request, error):
328+
def _process_request_error(self, request, error):
329329
detail = (error.parsed.data or {}).get("detail", error.message)
330330
logger.debug(
331331
f"Got Zyte API error (status={error.status}, "

scrapy_zyte_api/utils.py

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import asyncio
22
import sys
33
from importlib.metadata import version
4-
from typing import Any, Coroutine, cast
4+
from typing import Any, Coroutine
55
from warnings import catch_warnings, filterwarnings
66

77
import scrapy
@@ -140,22 +140,6 @@ def maybe_deferred_to_future(
140140
return deferred_to_future(d)
141141

142142

143-
def _call_later(func, *args):
144-
try:
145-
from scrapy.utils.asyncio import call_later # noqa: F401
146-
except ImportError: # Scrapy < 2.14
147-
from twisted.internet import reactor
148-
from twisted.internet.interfaces import IReactorCore
149-
150-
reactor = cast(IReactorCore, reactor)
151-
reactor.callLater(0, func, *args)
152-
else:
153-
import asyncio
154-
155-
loop = asyncio.get_event_loop()
156-
loop.call_soon(func, *args)
157-
158-
159143
try:
160144
from scrapy.utils.reactor import is_reactor_installed as _is_reactor_installed
161145
except ImportError: # Scrapy < 2.14

0 commit comments

Comments
 (0)