-
Notifications
You must be signed in to change notification settings - Fork 22
Open
Description
Based on a local tox -e provider.
Breakages:
downloader._get_slot()called inscrapy_zyte_api._middlewares._BaseMiddleware.slot_request()and in some tests no longer has aspiderargument (we can reintroduce it if we really want)create_instance()called in tests (we already have abuild_from_crawler()implementation for Scrapy versions that don't have it inscrapy_zyte_api.utils, we should just switch to it)HTTP10DownloadHandlerused in the addon tests (I filed this earlier as Don't useHTTP10DownloadHandlerin the tests #245, we can define our own dummy handler for this test I think)
Deprecations (some of them are from older versions):
- required
spiderargument of middlewares and pipelines and passing it to base class methods start_requests()in test spidersExecutionEngine.close_spider()called in several placesExecutionEngine.download()in_SessionManagerandZyteApiProvider
Metadata
Metadata
Assignees
Labels
No labels