adding pre-commit config files

Author: Emmanuel Rondan

.bandit.yml

@@ -1,3 +1,6 @@
 skips:
 - B101  # assert_used, needed for mypy
-exclude_dirs: ['tests']
+- B311
+- B320
+- B410
+exclude_dirs: ['tests']

.git-blame-ignore-revs

@@ -0,0 +1,2 @@
+# applying pre-commit hooks to the project
+e00df278aa8602b18e7c3525191b843d88334c8f

.github/workflows/main.yml

@@ -17,20 +17,6 @@ jobs:
         - python-version: "2.7"
           env:
             TOXENV: py
-        - python-version: "3.4"
-          env:
-            TOXENV: py34
-        # 3.5 cannot be tested in CI
-        # https://github.com/MatteoH2O1999/setup-python/issues/49#issuecomment-2209940822
-        - python-version: "3.6"
-          env:
-            TOXENV: py
-        - python-version: "3.7"
-          env:
-            TOXENV: py
-        - python-version: "3.8"
-          env:
-            TOXENV: py
         - python-version: "3.9"
           env:
             TOXENV: py
@@ -76,3 +62,8 @@ jobs:
         run: tox
       - name: Upload coverage.xml to codecov
         uses: codecov/codecov-action@v1
+  pre-commit:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+    - uses: pre-commit/[email protected]

.isort.cfg

@@ -0,0 +1,2 @@
+[settings]
+profile = black

.pre-commit-config.yaml

@@ -1,6 +1,18 @@
 repos:
 - repo: https://github.com/PyCQA/bandit
-  rev: 1.7.10
+  rev: 1.7.9
   hooks:
   - id: bandit
     args: [-r, -c, .bandit.yml]
+- repo: https://github.com/psf/black.git
+  rev: 24.8.0
+  hooks:
+  - id: black
+- repo: https://github.com/PyCQA/flake8
+  rev: 7.1.1
+  hooks:
+  - id: flake8
+- repo: https://github.com/pycqa/isort
+  rev: 5.13.2
+  hooks:
+  - id: isort

setup.py

@@ -5,41 +5,36 @@
 
 
 setup(
-    name='scrapy-zyte-smartproxy',
-    version='2.3.5',
-    license='BSD',
-    description='Scrapy middleware for Zyte Smart Proxy Manager',
+    name="scrapy-zyte-smartproxy",
+    version="2.3.5",
+    license="BSD",
+    description="Scrapy middleware for Zyte Smart Proxy Manager",
     long_description=readme,
     long_description_content_type="text/x-rst",
-    maintainer='Raul Gallegos',
-    maintainer_email='[email protected]',
-    author='Zyte',
-    author_email='[email protected]',
-    url='https://github.com/scrapy-plugins/scrapy-zyte-smartproxy',
-    packages=['scrapy_zyte_smartproxy'],
-    platforms=['Any'],
+    maintainer="Raul Gallegos",
+    maintainer_email="[email protected]",
+    author="Zyte",
+    author_email="[email protected]",
+    url="https://github.com/scrapy-plugins/scrapy-zyte-smartproxy",
+    packages=["scrapy_zyte_smartproxy"],
+    platforms=["Any"],
     classifiers=[
-        'Development Status :: 5 - Production/Stable',
-        'License :: OSI Approved :: BSD License',
-        'Operating System :: OS Independent',
-        'Programming Language :: Python',
-        'Programming Language :: Python :: 2.7',
-        'Programming Language :: Python :: 3.4',
-        'Programming Language :: Python :: 3.5',
-        'Programming Language :: Python :: 3.6',
-        'Programming Language :: Python :: 3.7',
-        'Programming Language :: Python :: 3.8',
-        'Programming Language :: Python :: 3.9',
-        'Programming Language :: Python :: 3.10',
-        'Programming Language :: Python :: 3.11',
-        'Programming Language :: Python :: 3.12',
-        'Programming Language :: Python :: 3.13',
-        'Framework :: Scrapy',
-        'Intended Audience :: Developers',
-        'Topic :: Internet :: WWW/HTTP',
-        'Topic :: Internet :: Proxy Servers',
-        'Topic :: Software Development :: Libraries :: Application Frameworks',
-        'Topic :: Software Development :: Libraries :: Python Modules',
+        "Development Status :: 5 - Production/Stable",
+        "License :: OSI Approved :: BSD License",
+        "Operating System :: OS Independent",
+        "Programming Language :: Python",
+        "Programming Language :: Python :: 2.7",
+        "Programming Language :: Python :: 3.9",
+        "Programming Language :: Python :: 3.10",
+        "Programming Language :: Python :: 3.11",
+        "Programming Language :: Python :: 3.12",
+        "Programming Language :: Python :: 3.13",
+        "Framework :: Scrapy",
+        "Intended Audience :: Developers",
+        "Topic :: Internet :: WWW/HTTP",
+        "Topic :: Internet :: Proxy Servers",
+        "Topic :: Software Development :: Libraries :: Application Frameworks",
+        "Topic :: Software Development :: Libraries :: Python Modules",
     ],
-    install_requires=['scrapy>=1.4.0', 'six', 'w3lib'],
+    install_requires=["scrapy>=1.4.0", "six", "w3lib"],
 )

tox.ini

@@ -1,6 +1,6 @@
 # tox.ini
 [tox]
-envlist = pre-commit,mypy,min,py27,py34,py35,py36,py37,py38,py39,py310,py311,py312,py313,docs
+envlist = pre-commit,mypy,min,py27,py39,py310,py311,py312,py313,docs
 
 [testenv]
 deps =
@@ -10,11 +10,9 @@ commands =
     py.test --doctest-modules --cov=scrapy_zyte_smartproxy {posargs:scrapy_zyte_smartproxy tests}
 
 [testenv:pre-commit]
-basepython = python3
-deps =
-    pre-commit
-commands =
-    pre-commit run {posargs:--all-files}
+deps = pre-commit
+commands = pre-commit run --all-files --show-diff-on-failure
+skip_install = true
 
 [testenv:mypy]
 basepython = python3.10
@@ -37,17 +35,6 @@ deps =
     w3lib==1.17.0
     -rtests/requirements.txt
 
-[testenv:py34]
-basepython = python3.4
-deps =
-    Scrapy
-    six
-    # Latest Twisted that does not install an embedded version of incremental
-    # that is incompatible with Python 3.4.
-    Twisted==16.4.1
-    w3lib
-    -rtests/requirements.txt
-
 [testenv:security]
 deps =
     bandit