Fix keep_fragments=True (#183)

* [FIX] avoid adding `#` after url

avoid adding `#` after url if there is no fragment.

* [FIX] avoid adding `#` after url when no fragment

* fix formatting

Co-authored-by: EltonChou <[email protected]>
Co-authored-by: Elton Chou <[email protected]>

Author: 3 people

tests/test_url.py

@@ -630,6 +630,12 @@ def test_url_query_cleaner_keep_fragments(self):
                 keep_fragments=True,
             ),
         )
+        self.assertEqual(
+            "product.html?id=200",
+            url_query_cleaner(
+                "product.html?id=200&foo=bar&name=wired", ["id"], keep_fragments=True
+            ),
+        )
 
     def test_path_to_file_uri(self):
         if os.name == "nt":

w3lib/url.py

@@ -275,7 +275,7 @@ def url_query_cleaner(
             querylist.append(ksv)
             seen.add(k)
     url = "?".join([base, sep.join(querylist)]) if querylist else base
-    if keep_fragments:
+    if keep_fragments and fragment:
         url += "#" + fragment
     return cast(str, url)