Text # quoting in safe_url_string

Author: Gallaecio

tests/test_url.py

@@ -219,6 +219,17 @@ def test_safe_url_port_number(self):
             safe_url_string(u"http://www.example.com:/résumé?q=résumé"),
             "http://www.example.com/r%C3%A9sum%C3%A9?q=r%C3%A9sum%C3%A9")
 
+    def test_safe_url_string_preserve_nonfragment_hash(self):
+        # don't decode `%23` to `#`
+        self.assertEqual(safe_url_string("http://www.example.com/path/to/%23/foo/bar"),
+                                          "http://www.example.com/path/to/%23/foo/bar")
+        self.assertEqual(safe_url_string("http://www.example.com/path/to/%23/foo/bar#frag"),
+                                          "http://www.example.com/path/to/%23/foo/bar#frag")
+        self.assertEqual(safe_url_string("http://www.example.com/path/to/%23/foo/bar?url=http%3A%2F%2Fwww.example.com%2Fpath%2Fto%2F%23%2Fbar%2Ffoo"),
+                                          "http://www.example.com/path/to/%23/foo/bar?url=http%3A%2F%2Fwww.example.com%2Fpath%2Fto%2F%23%2Fbar%2Ffoo")
+        self.assertEqual(safe_url_string("http://www.example.com/path/to/%23/foo/bar?url=http%3A%2F%2Fwww.example.com%2F%2Fpath%2Fto%2F%23%2Fbar%2Ffoo#frag"),
+                                          "http://www.example.com/path/to/%23/foo/bar?url=http%3A%2F%2Fwww.example.com%2F%2Fpath%2Fto%2F%23%2Fbar%2Ffoo#frag")
+
     def test_safe_download_url(self):
         self.assertEqual(safe_download_url('http://www.example.org'),
                          'http://www.example.org/')

w3lib/url.py

@@ -75,7 +75,7 @@ def safe_url_string(url, encoding='utf8', path_encoding='utf8', quote_path=True)
 
     # default encoding for path component SHOULD be UTF-8
     if quote_path:
-        path = quote(to_bytes(parts.path, path_encoding), _safe_chars)
+        path = quote(to_bytes(parts.path, path_encoding), _path_safe_chars)
     else:
         path = to_native_str(parts.path)