more type hints

Author: lucywang000

tests/test_encoding.py

@@ -37,14 +37,16 @@ def test_bom(self):
         utf32le = b'\xff\xfe\x00\x00\x34\x6c\x00\x00'
         for string in (utf16be, utf16le, utf32be, utf32le):
             bom_encoding, bom = read_bom(string)
+            assert bom_encoding is not None
+            assert bom is not None
             decoded = string[len(bom):].decode(bom_encoding)
             self.assertEqual(water_unicode, decoded)
         # Body without BOM
-        enc, bom = read_bom("foo")
+        enc, bom = read_bom(b"foo")
         self.assertEqual(enc, None)
         self.assertEqual(bom, None)
         # Empty body
-        enc, bom = read_bom("")
+        enc, bom = read_bom(b"")
         self.assertEqual(enc, None)
         self.assertEqual(bom, None)
 

tests/test_http.py

@@ -1,6 +1,6 @@
 import unittest
 from collections import OrderedDict
-from w3lib.http import (basic_auth_header,
+from w3lib.http import (HeadersDictInput, basic_auth_header,
                         headers_dict_to_raw, headers_raw_to_dict)
 
 __doctests__ = ['w3lib.http'] # for trial support
@@ -43,7 +43,7 @@ def test_headers_dict_to_raw(self):
         )
 
     def test_headers_dict_to_raw_listtuple(self):
-        dct = OrderedDict([
+        dct: HeadersDictInput = OrderedDict([
             (b'Content-type', [b'text/html']),
             (b'Accept', [b'gzip'])
         ])
@@ -80,7 +80,7 @@ def test_headers_dict_to_raw_listtuple(self):
         )
 
     def test_headers_dict_to_raw_wrong_values(self):
-        dct = OrderedDict([
+        dct: HeadersDictInput = OrderedDict([
             (b'Content-type', 0),
         ])
         self.assertEqual(

tests/test_url.py

@@ -370,7 +370,7 @@ def test_add_or_replace_parameters(self):
     def test_add_or_replace_parameters_does_not_change_input_param(self):
         url = 'http://domain/test?arg=original'
         input_param = {'arg': 'value'}
-        new_url = add_or_replace_parameters(url, input_param)  # noqa
+        add_or_replace_parameters(url, input_param)  # noqa
         self.assertEqual(input_param, {'arg': 'value'})
 
     def test_url_query_cleaner(self):
@@ -568,11 +568,14 @@ def test_normalize_percent_encoding_in_query_arguments(self):
 
     def test_non_ascii_percent_encoding_in_paths(self):
         self.assertEqual(canonicalize_url("http://www.example.com/a do?a=1"),
-                                          "http://www.example.com/a%20do?a=1"),
+                                          "http://www.example.com/a%20do?a=1")
+
         self.assertEqual(canonicalize_url("http://www.example.com/a %20do?a=1"),
-                                          "http://www.example.com/a%20%20do?a=1"),
+                                          "http://www.example.com/a%20%20do?a=1")
+
         self.assertEqual(canonicalize_url("http://www.example.com/a do£.html?a=1"),
                                           "http://www.example.com/a%20do%C2%A3.html?a=1")
+
         self.assertEqual(canonicalize_url(b"http://www.example.com/a do\xc2\xa3.html?a=1"),
                                           "http://www.example.com/a%20do%C2%A3.html?a=1")