Skip to content

Conversation

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Mar 26, 2021

Suggested by @kmike.

To do:

  • Raise the warning stack level by 1.

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #170 (31b8ecd) into master (ef5c110) will increase coverage by 0.97%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   93.72%   94.70%   +0.97%     
==========================================
  Files           6        6              
  Lines         430      434       +4     
  Branches       88       88              
==========================================
+ Hits          403      411       +8     
+ Misses         19       12       -7     
- Partials        8       11       +3     
Impacted Files Coverage Δ
w3lib/url.py 97.90% <100.00%> (ø)
w3lib/util.py 64.70% <100.00%> (+18.03%) ⬆️

@kmike
Copy link
Member

kmike commented Mar 26, 2021

hey @Gallaecio! Could you please check that stacklevels make sense?

@wRAR wRAR merged commit 0fd1590 into scrapy:master Jul 26, 2021
@kmike kmike added this to the 2.0.0 milestone Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants