Encode hostname directly instead of netloc

[Laerte]

This fix the issue

• w3lib.url.safe_url_string incorrectly encode IDNA domain with port #171

[codecov]

Codecov Report

Merging #174 (ff8338c) into master (d9763db) will decrease coverage by 0.06%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   95.68%   95.61%   -0.07%     
==========================================
  Files           7        7              
  Lines         463      479      +16     
  Branches       88       94       +6     
==========================================
+ Hits          443      458      +15     
  Misses         10       10              
- Partials       10       11       +1     

Impacted Files	Coverage Δ
w3lib/url.py	97.71% <95.23%> (-0.32%)	⬇️

[Laerte]

@Gallaecio The CI is failing on Build / build (3.9, pylint) (pull_request) but its not related to the code that i changed.

ERROR: InvocationError for command /home/runner/work/w3lib/w3lib/.tox/pylint/bin/pylint conftest.py docs setup.py tests w3lib (exited with code 16)

[Gallaecio]

I need to delay my review until I have the time to carefully look into the potential issues with encoding and decoding each separate field.

[Gallaecio]

@Laerte Sorry for the wait, I finally had a proper look.

I have created a pull request against your branch, https://github.com/Laerte/w3lib/pull/1, please have a look when you get a chance.

quote was indeed needed for username and password, but _safe_chars was not the right character allow-list for those fields.

[Laerte]

@Gallaecio Thank you! Do you think we can merge this to master or need more changes?

[Gallaecio]

It looks good to me. I’ll try and get someone else to have a look as well before we merge.

[Laerte]

@wRAR Do you mind to take a look on this one? Thanks!