Fix issue #162 add different regex pattern to search for meta tags

[AngelikiBoura]

Changes:

• Add a second regular expression pattern with different ordering in meta tags
• Test that redirection occurs when the attributes of the meta tag are differently ordered

[codecov]

Codecov Report

Merging #179 (e594385) into master (d9763db) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e594385 differs from pull request most recent head a0a0b0d. Consider uploading reports for the commit a0a0b0d to get more accurate results

@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files           7        7           
  Lines         463      464    +1     
  Branches       88       89    +1     
=======================================
+ Hits          443      444    +1     
  Misses         10       10           
  Partials       10       10           

Impacted Files	Coverage Δ
w3lib/html.py	95.49% <100.00%> (+0.04%)	⬆️
w3lib/url.py	98.02% <100.00%> (ø)

[Gallaecio]

Can you run black on the code? It seems even something in the main branch fails the black check now, we probably need to freeze the version of black that we use.

[AngelikiBoura]

I ran it with tox and this is the result:

angeliki@angeliki-B550M-DS3H:~/lab/library/w3lib$ tox -e black
GLOB sdist-make: /home/angeliki/lab/library/w3lib/setup.py
black inst-nodeps: /home/angeliki/lab/library/w3lib/.tox/.tmp/package/1/w3lib-1.22.0.zip
black installed: black==22.3.0,click==8.1.3,mypy-extensions==0.4.3,pathspec==0.9.0,platformdirs==2.5.2,tomli==2.0.1,typing-extensions==4.2.0,w3lib==1.22.0
black run-test-pre: PYTHONHASHSEED='1496754552'
black run-test: commands[0] | black --check conftest.py setup.py tests w3lib
would reformat w3lib/html.py
would reformat w3lib/url.py
would reformat tests/test_html.py

Oh no! 💥 💔 💥
3 files would be reformatted, 12 files would be left unchanged.
ERROR: InvocationError for command /home/angeliki/lab/library/w3lib/.tox/black/bin/black --check conftest.py setup.py tests w3lib (exited with code 1)
___________________________________ summary ____________________________________
ERROR: black: commands failed

[Gallaecio]

Instead of using tox, which just checks the files, if you run black conftest.py setup.py tests w3lib (the command that tox runs, without --check) you can actually modify the required files so that tox -e black passes.

[AngelikiBoura]

I ran black conftest.py setup.py tests w3lib but it only changed tests/test_html.py and not the other two. So tox -e black still fails.

[Gallaecio]

You were probably using an older black. I have run the latest black, and frozen black in tox.ini so that this will not happen again (that a newer black causes code already in the main branch to stop passing CI).

[Gallaecio]

Addressed. Sorry for the unrelated noise, I was not very careful when I added those static checks 🤦

[Gallaecio]

Thanks!

[AngelikiBoura]

No problem! Thank you, too.

[kmike]

Thanks @AngelikiBoura!