Skip to content

Commit 7546200

Browse files
chore: [UEPR-56] resolve merge conflicts
2 parents 906150d + fa5ecab commit 7546200

File tree

5 files changed

+23
-14
lines changed

5 files changed

+23
-14
lines changed

packages/scratch-gui/src/components/context-menu/context-menu.jsx

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,43 +1,42 @@
11
import React from 'react';
22
import PropTypes from 'prop-types';
3-
// eslint-disable-next-line import/no-unresolved
4-
import {ContextMenuItem} from '@radix-ui/react-context-menu';
3+
import ContextMenu from '../../lib/radix-ui-context-menu.js';
54
import classNames from 'classnames';
65
import styles from './context-menu.css';
76

87
const StyledMenuItem = ({children, ...props}) => (
9-
<ContextMenuItem
8+
<ContextMenu.ContextMenuItem
109
className={styles.menuItem}
1110
{...props}
1211
>
1312
{children}
14-
</ContextMenuItem>
13+
</ContextMenu.ContextMenuItem>
1514
);
1615

1716
StyledMenuItem.propTypes = {
1817
children: PropTypes.node
1918
};
2019

2120
const BorderedMenuItem = ({children, ...props}) => (
22-
<ContextMenuItem
21+
<ContextMenu.ContextMenuItem
2322
className={classNames(styles.menuItem, styles.menuItemBordered)}
2423
{...props}
2524
>
2625
{children}
27-
</ContextMenuItem>
26+
</ContextMenu.ContextMenuItem>
2827
);
2928

3029
BorderedMenuItem.propTypes = {
3130
children: PropTypes.node
3231
};
3332

3433
const DangerousMenuItem = ({children, ...props}) => (
35-
<ContextMenuItem
34+
<ContextMenu.ContextMenuItem
3635
className={classNames(styles.menuItem, styles.menuItemBordered, styles.menuItemDanger)}
3736
{...props}
3837
>
3938
{children}
40-
</ContextMenuItem>
39+
</ContextMenu.ContextMenuItem>
4140
);
4241

4342
DangerousMenuItem.propTypes = {

packages/scratch-gui/src/components/monitor/monitor.jsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@ import React from 'react';
22
import PropTypes from 'prop-types';
33
import Draggable from 'react-draggable';
44
import {FormattedMessage} from 'react-intl';
5-
// eslint-disable-next-line import/no-unresolved
6-
import * as ContextMenu from '@radix-ui/react-context-menu';
5+
import ContextMenu from '../../lib/radix-ui-context-menu.js';
76
import Box from '../box/box.jsx';
87
import DefaultMonitor from './default-monitor.jsx';
98
import LargeMonitor from './large-monitor.jsx';

packages/scratch-gui/src/components/sprite-selector-item/sprite-selector-item.jsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ import styles from './sprite-selector-item.css';
66
import contextMenuStyles from '../context-menu/context-menu.css';
77
import {DangerousMenuItem, MenuItem} from '../context-menu/context-menu.jsx';
88
import {FormattedMessage} from 'react-intl';
9-
// eslint-disable-next-line import/no-unresolved
10-
import * as ContextMenu from '@radix-ui/react-context-menu';
9+
import ContextMenu from '../../lib/radix-ui-context-menu.js';
1110

1211
const SpriteSelectorItem = props => {
1312
useEffect(() => {

packages/scratch-gui/src/containers/sprite-selector-item.jsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,10 @@ class SpriteSelectorItem extends React.PureComponent {
127127
this.setState({isDeletePromptOpen: false});
128128
}
129129
setRef (component) {
130-
// Access the DOM node using .elem because it is going through ContextMenuTrigger
131-
this.ref = component;
130+
// The ref is on the element inside ContextMenu.Trigger
131+
if (component) {
132+
this.ref = component;
133+
}
132134
}
133135
render () {
134136
const {
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
/* eslint-disable import/no-unresolved */
2+
/*
3+
https://github.com/import-js/eslint-plugin-import/issues/1810
4+
eslint-plugin-import is not aware of exports definition in package.json
5+
meaning we should disable linting for this import or use require instead
6+
moved the import in a separate file so that the disabling happens in one place only
7+
*/
8+
import * as ContextMenu from '@radix-ui/react-context-menu';
9+
10+
export default ContextMenu;

0 commit comments

Comments
 (0)