fix: remove loading extension listener to prevent multiple alerts when moving from PDP to editor

adzhindzhi · adzhindzhi · commit a84b993de833 · 2025-09-16T14:42:35.000+03:00
diff --git a/packages/scratch-gui/src/lib/vm-listener-hoc.jsx b/packages/scratch-gui/src/lib/vm-listener-hoc.jsx
@@ -69,6 +69,8 @@ const vmListenerHOC = function (WrappedComponent) {
         }
         componentWillUnmount () {
             this.props.vm.removeListener('PERIPHERAL_CONNECTION_LOST_ERROR', this.props.onShowExtensionAlert);
+            this.props.vm.removeListener('EXTENSION_DATA_LOADING', this.props.onExtensionDataLoading);
+            
             if (this.props.attachKeyboardEvents) {
                 document.removeEventListener('keydown', this.handleKeyDown);
                 document.removeEventListener('keyup', this.handleKeyUp);

Original file line number	Diff line number	Diff line change
`@@ -69,6 +69,8 @@ const vmListenerHOC = function (WrappedComponent) {`
`69`	`69`	`}`
`70`	`70`	`componentWillUnmount () {`
`71`	`71`	`this.props.vm.removeListener('PERIPHERAL_CONNECTION_LOST_ERROR', this.props.onShowExtensionAlert);`
	`72`	`+ this.props.vm.removeListener('EXTENSION_DATA_LOADING', this.props.onExtensionDataLoading);`
	`73`	`+`
`72`	`74`	`if (this.props.attachKeyboardEvents) {`
`73`	`75`	`document.removeEventListener('keydown', this.handleKeyDown);`
`74`	`76`	`document.removeEventListener('keyup', this.handleKeyUp);`