fix: update checks and default related to manual thumbnail updates

Author: KManolov3

packages/scratch-gui/src/components/stage-header/stage-header.jsx

@@ -207,13 +207,13 @@ StageHeaderComponent.propTypes = {
     intl: intlShape,
     isFullScreen: PropTypes.bool.isRequired,
     isPlayerOnly: PropTypes.bool.isRequired,
-    manuallySaveThumbnails: PropTypes.bool.isRequired,
+    manuallySaveThumbnails: PropTypes.bool,
     onKeyPress: PropTypes.func.isRequired,
     onSetStageFull: PropTypes.func.isRequired,
     onSetStageLarge: PropTypes.func.isRequired,
     onSetStageSmall: PropTypes.func.isRequired,
     onSetStageUnFull: PropTypes.func.isRequired,
-    onUpdateProjectThumbnail: PropTypes.func.isRequired,
+    onUpdateProjectThumbnail: PropTypes.func,
     projectId: PropTypes.number.isRequired,
     showBranding: PropTypes.bool.isRequired,
     stageSizeMode: PropTypes.oneOf(Object.keys(STAGE_SIZE_MODES)),

packages/scratch-gui/src/lib/project-saver-hoc.jsx

@@ -74,6 +74,7 @@ const ProjectSaverHOC = function (WrappedComponent) {
 
             if (
                 !this.props.manuallySaveThumbnails &&
+                this.props.onUpdateProjectThumbnail &&
                 this.props.saveThumbnailOnLoad &&
                 this.props.isShowingWithId &&
                 !prevProps.isShowingWithId
@@ -268,9 +269,10 @@ const ProjectSaverHOC = function (WrappedComponent) {
                 .then(response => {
                     this.props.onSetProjectUnchanged();
                     const id = response.id.toString();
-                    if ((!this.props.manuallySaveThumbnails && id && this.props.onUpdateProjectThumbnail) ||
+                    if (this.props.onUpdateProjectThumbnail && id && (
+                        !this.props.manuallySaveThumbnails ||
                         // Always save thumbnail on project creation
-                        options?.isCreatingProject) {
+                        options?.isCreatingProject)) {
                         storeProjectThumbnail(this.props.vm, dataURI => {
                             this.props.onUpdateProjectThumbnail(
                                 id,
@@ -430,6 +432,7 @@ const ProjectSaverHOC = function (WrappedComponent) {
             isManualUpdating: getIsManualUpdating(loadingState),
             loadingState: loadingState,
             locale: state.locales.locale,
+            manuallySaveThumbnails: ownProps.manuallySaveThumbnails ?? false,
             onUpdateProjectThumbnail:
                 ownProps.onUpdateProjectThumbnail ??
                 storage.saveProjectThumbnail?.bind(storage),