Skip to content

Commit 256b84b

Browse files
authored
Merge pull request #9652 from scratchfoundation/taller-screen-for-tests
test: boost screen height to fix l10n test
2 parents 43cd8f2 + 9d851ca commit 256b84b

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

test/helpers/selenium-helper.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,8 +236,13 @@ class SeleniumHelper {
236236
const outerError = new Error(`loadUri failed with arguments:\n\turi: ${uri}`);
237237
try {
238238
await this.setTitle(`loadUri ${uri}`);
239+
// TODO: The height is set artificially high to fix this test:
240+
// 'Loading with locale shows correct translation for string length block parameter'
241+
// which fails because the block is offscreen.
242+
// We should set this back to 1024x768 once we find a good way to fix that test.
243+
// Using `scrollIntoView` didn't seem to do the trick.
239244
const WINDOW_WIDTH = 1024;
240-
const WINDOW_HEIGHT = 768;
245+
const WINDOW_HEIGHT = 960;
241246
await this.driver
242247
.get(`file://${uri}`);
243248
await this.driver

0 commit comments

Comments
 (0)