style: update configuration for eslint@9, e-c-s@12

and fix lint errors introduced by these updates

Author: cwillisf

.eslintignore

@@ -0,0 +1,47 @@
+import {eslintConfigScratch} from 'eslint-config-scratch';
+import {globalIgnores} from 'eslint/config';
+import globals from 'globals';
+
+export default eslintConfigScratch.defineConfig(
+    eslintConfigScratch.legacy.base,
+    {
+        files: [
+            '*.{js,cjs,mjs,ts}' // for example, webpack.config.js
+        ],
+        extends: [eslintConfigScratch.legacy.node]
+    },
+    {
+        files: ['src/**/*.{js,cjs,mjs,jsx,ts,tsx}'],
+        extends: [
+            eslintConfigScratch.legacy.es6,
+            eslintConfigScratch.legacy.typescript
+        ],
+        languageOptions: {
+            globals: globals.node
+        },
+        rules: {
+            // TODO: Enable these rules after fixing existing violations. This will change the API!
+            '@typescript-eslint/no-redeclare': 'off', // allow types and values with the same name
+            '@typescript-eslint/prefer-promise-reject-errors': 'off' // allow rejecting with non-Error values
+        }
+    },
+    {
+        files: ['test/**/*.{js,cjs,mjs,jsx,ts,tsx}'],
+        extends: [
+            eslintConfigScratch.legacy.es6
+        ],
+        languageOptions: {
+            globals: {
+                ...globals.jest,
+                ...globals.node
+            }
+        },
+        rules: {
+            'no-console': 'off'
+        }
+    },
+    globalIgnores([
+        'dist/**',
+        'node_modules/**'
+    ])
+);

.eslintrc.js

@@ -21,7 +21,7 @@
     "test": "npm run test:lint && jest \"test[\\\\/](unit|integration)\"",
     "test:clearCache": "jest --clearCache",
     "test:integration": "jest \"test[\\\\/]integration\"",
-    "test:lint": "eslint .",
+    "test:lint": "eslint",
     "test:unit": "jest \"test[\\\\/]unit\"",
     "version": "json -f package.json -I -e \"this.repository.sha = '$(git log -n1 --pretty=format:%H)'\"",
     "watch": "webpack --watch"

eslint.config.mjs

@@ -97,7 +97,7 @@ export class ScratchStorage {
      * @param {Helper} helper - the helper to be added.
      * @param {number} [priority] - the priority for this new helper (default: 0).
      */
-    addHelper (helper: Helper, priority: number = 0) {
+    addHelper (helper: Helper, priority = 0) {
         this._helpers.push({helper, priority});
         this._helpers.sort((a, b) => b.priority - a.priority);
     }

package.json

@@ -2,9 +2,9 @@ export type ScratchGetRequest = {url: string} & RequestInit;
 export type ScratchSendRequest = {url: string, withCredentials?: boolean} & RequestInit;
 
 export interface Tool {
-  get isGetSupported (): boolean;
-  get (request: ScratchGetRequest): Promise<Uint8Array | null>;
+    get isGetSupported (): boolean;
+    get (request: ScratchGetRequest): Promise<Uint8Array | null>;
 
-  get isSendSupported (): boolean;
-  send (request: ScratchSendRequest): Promise<string>;
+    get isSendSupported (): boolean;
+    send (request: ScratchSendRequest): Promise<string>;
 }

src/.eslintrc.js

@@ -208,7 +208,7 @@ export default class WebHelper extends Helper {
                 if (typeof body === 'string') {
                     try {
                         body = JSON.parse(body);
-                    } catch (parseError) {
+                    } catch (parseError) { // eslint-disable-line @typescript-eslint/no-unused-vars
                         // If it's not parseable, then we can't add the id even
                         // if we want to, so stop here
                         return body;

src/ScratchStorage.ts

@@ -106,7 +106,6 @@ test('load', () => {
                 }
 
                 if (e instanceof Array) {
-                    /* global AggregateError */
                     // we must have >1 error, so report it as an AggregateError (supported in Node 15+)
                     e = new AggregateError(
                         e.flat(),
@@ -132,7 +131,6 @@ test('load', () => {
         expect(asset.clean).toBeTruthy();
 
         if (assetInfo.md5) {
-            // eslint-disable-next-line jest/no-conditional-expect
             expect(md5(asset.data)).toBe(assetInfo.md5);
         }
     });