fix: address review feedback

Thanks @kchadha and @cwillisf!

Author: Ray Schamp

src/BuiltinHelper.js

@@ -113,12 +113,12 @@ class BuiltinHelper extends Helper {
      * @param {AssetType} assetType - The type of the asset to cache.
      * @param {DataFormat} dataFormat - The dataFormat of the data for the cached asset.
      * @param {Buffer} data - The data for the cached asset.
-     * @param {string} id - The id for the cached asset.
+     * @param {(string|number)} id - The id for the cached asset.
      * @returns {string} The calculated id of the cached asset, or the supplied id if the asset is mutable.
      */
     store (assetType, dataFormat, data, id) {
         if (!dataFormat) throw new Error('Data cached without specifying its format');
-        if (id !== null && typeof id !== 'undefined') {
+        if (id !== '' && id !== null && typeof id !== 'undefined') {
             if (this.assets.hasOwnProperty(id) && assetType.immutable) return id;
         } else if (assetType.immutable) {
             id = md5(data);

src/ScratchStorage.js

@@ -187,10 +187,10 @@ class ScratchStorage {
     /**
      * Store an asset by type & ID.
      * @param {AssetType} assetType - The type of asset to fetch. This also determines which asset store to use.
-     * @param {DataFormat} [dataFormat] - Optional: load this format instead of the AssetType's default.
-     * @param {DataFormat} [data] - Optional: store this data, rather than the data in the asset
-     * @param {?string} assetId - The ID of the asset to fetch: a project ID, MD5, etc.
-     * @return {Promise.<id, title>} A promise for asset metadata
+     * @param {?DataFormat} [dataFormat] - Optional: load this format instead of the AssetType's default.
+     * @param {Buffer} data - Data to store for the asset
+     * @param {?string} [assetId] - The ID of the asset to fetch: a project ID, MD5, etc.
+     * @return {Promise.<object>} A promise for asset metadata
      */
     store (assetType, dataFormat, data, assetId) {
         dataFormat = dataFormat || assetType.runtimeFormat;

src/WebHelper.js

@@ -39,8 +39,8 @@ class WebHelper extends Helper {
     }
 
     /**
-     * Register a web-based source for assets. Sources will be checked in order of registration.
-     * @param {Array.<AssetType>} types - The types of asset provided by this source.
+     * Register a web-based store for assets. Sources will be checked in order of registration.
+     * @param {Array.<AssetType>} types - The types of asset provided by this store.
      * @param {UrlFunction} getFunction - A function which computes a GET URL for an Asset
      * @param {UrlFunction} createFunction - A function which computes a POST URL for an Asset
      * @param {UrlFunction} updateFunction - A function which computes a PUT URL for an Asset
@@ -130,9 +130,9 @@ class WebHelper extends Helper {
     store (assetType, dataFormat, data, assetId) {
         const asset = new Asset(assetType, assetId, dataFormat);
         // If we have an asset id, we should update, otherwise create to get an id
-        const create = assetId === null || typeof assetId === 'undefined';
+        const create = assetId !== '' || assetId === null || typeof assetId === 'undefined';
 
-        // Use the first source with the appropriate asset type and url function
+        // Use the first store with the appropriate asset type and url function
         const store = this.stores.filter(s =>
             // Only use stores for the incoming asset type
             s.types.indexOf(assetType.name) !== -1 && (