fix: update fact

Author: scream4ik

memstate/storage.py

@@ -1,5 +1,6 @@
 import copy
 import threading
+import uuid
 from datetime import datetime, timezone
 from typing import Any, Callable
 
@@ -133,6 +134,8 @@ def commit(
     def commit_model(
         self,
         model: BaseModel,
+        fact_id: str | None = None,
+        source: str | None = None,
         session_id: str | None = None,
         ephemeral: bool = False,
         actor: str | None = None,
@@ -150,7 +153,7 @@ def commit_model(
                 f"Please call memory.register_schema('your_type_name', {model.__class__.__name__}) first."
             )
 
-        fact = Fact(type=schema_type, payload=model.model_dump())
+        fact = Fact(id=fact_id or str(uuid.uuid4()), type=schema_type, payload=model.model_dump(), source=source)
 
         return self.commit(fact, session_id=session_id, ephemeral=ephemeral, actor=actor, reason=reason)
 

tests/test_storage.py

@@ -146,3 +146,40 @@ def test_commit_model_raises_on_unregistered(memory):
 
     with pytest.raises(MemoryStoreError, match="is not registered"):
         memory.commit_model(unknown)
+
+
+def test_commit_model_create_vs_update(memory):
+    memory.register_schema("user", User)
+
+    user = User(name="Survivor", age=50)
+    fid = memory.commit_model(user)
+
+    assert fid is not None
+    data_v1 = memory.storage.load(fid)
+    assert data_v1["payload"]["name"] == "Survivor"
+    assert data_v1["payload"]["age"] == 50
+
+    user_v2 = User(name="Survivor", age=55)
+
+    fid_updated = memory.commit_model(user_v2, fact_id=fid)
+
+    assert fid_updated == fid
+
+    data_v2 = memory.storage.load(fid)
+    assert data_v2["payload"]["name"] == "Survivor"
+    assert data_v2["payload"]["age"] == 55
+
+    all_facts = memory.storage.query(type_filter="user")
+    assert len(all_facts) == 1
+
+
+def test_commit_model_without_id_creates_duplicate(memory):
+    memory.register_schema("user", User)
+    user = User(name="Survivor", age=50)
+
+    id1 = memory.commit_model(user)
+    id2 = memory.commit_model(user)
+
+    assert id1 != id2
+    all_facts = memory.storage.query(type_filter="user")
+    assert len(all_facts) == 2