Chore/removing retrying for lobby wait (#34)

* Chore: remove retry logic for lobby wait errors and update configuration parameters

Author: ddilushan

.env.example

@@ -3,8 +3,14 @@ AUTH_BASE_URL_V2=http://host.docker.internal:8081/v2
 
 # Meeting recording configuration
 MAX_RECORDING_DURATION_MINUTES=180
-MEETING_INACTIVITY_MINUTES=15
+# Silence detection timeout in minutes (how long to wait before ending due to inactivity)
+MEETING_INACTIVITY_MINUTES=2
 INACTIVITY_DETECTION_START_DELAY_MINUTES=5
+# How long to wait at lobby before timing out (in minutes)
+JOIN_WAIT_TIME_MINUTES=2
+# Number of retries for transient errors (WaitingAtLobbyRetryError never retries)
+# RETRY_COUNT=2 means: 1 initial attempt + 2 retries = 3 total attempts
+RETRY_COUNT=2
 
 # GCP bucket configuration for uploading debugging screenshots
 GCP_ACCESS_KEY_ID=

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "meeting-bot",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "Run meeting bots for Google Meet, Microsoft Teams and Zoom",
   "main": "index.js",
   "license": "MIT",

package.json

@@ -1,6 +1,7 @@
 import { Logger } from 'winston';
-import { KnownError } from '../error';
+import { KnownError, WaitingAtLobbyRetryError } from '../error';
 import { getErrorType } from '../util/logger';
+import config from '../config';
 
 export interface MeetingJoinParams {
   url: string;
@@ -45,6 +46,12 @@ export const joinMeetWithRetry = async (
       timezone,
     });
   } catch (error) {
+    // Never retry WaitingAtLobbyRetryError - if user doesn't admit bot, retrying won't help
+    if (error instanceof WaitingAtLobbyRetryError) {
+      logger.error('WaitingAtLobbyRetryError - not retrying:', error.message);
+      throw error;
+    }
+
     if (error instanceof KnownError && !error.retryable) {
       logger.error('KnownError is not retryable:', error.name, error.message);
       throw error;
@@ -57,9 +64,9 @@ export const joinMeetWithRetry = async (
 
     retryCount += 1;
     await sleep(retryCount * 30000);
-    if (retryCount < 3) {
+    if (retryCount <= config.retryCount) {
       if (retryCount) {
-        logger.warn(`Retry count: ${retryCount}`);
+        logger.warn(`Retry attempt: ${retryCount}/${config.retryCount}`);
       }
       await joinMeetWithRetry(processor, bearerToken, url, name, teamId, timezone, userId, retryCount, eventId, botId, logger);
     } else {

src/app/common.ts

@@ -344,7 +344,8 @@ export class GoogleMeetBot extends MeetBotBase {
 
         this._logger.error('Cant finish wait at the lobby check', { userDenied, waitingAtLobbySuccess, bodyText });
 
-        throw new WaitingAtLobbyRetryError('Google Meet bot could not enter the meeting...', bodyText ?? '', !userDenied, 2);
+        // Don't retry lobby errors - if user doesn't admit bot, retrying won't help
+        throw new WaitingAtLobbyRetryError('Google Meet bot could not enter the meeting...', bodyText ?? '', false, 0);
       }
     } catch(lobbyError) {
       this._logger.info('Closing the browser on error...', lobbyError);

src/bots/GoogleMeetBot.ts

@@ -306,8 +306,9 @@ export class MicrosoftTeamsBot extends MeetBotBase {
 
       this._logger.error('Closing the browser on error...', error);
       await this.page.context().browser()?.close();
-      
-      throw new WaitingAtLobbyRetryError('Microsoft Teams Meeting bot could not enter the meeting...', bodyText ?? '', !userDenied, 2);
+
+      // Don't retry lobby errors - if user doesn't admit bot, retrying won't help
+      throw new WaitingAtLobbyRetryError('Microsoft Teams Meeting bot could not enter the meeting...', bodyText ?? '', false, 0);
     }
 
     pushState('joined');
@@ -508,10 +509,8 @@ export class MicrosoftTeamsBot extends MeetBotBase {
       });
 
       // Start audio silence detection (runs in parallel with participant detection)
-      // inactivityLimit is in milliseconds (default 2 minutes = 120000ms)
-      const inactivityLimitMs = config.inactivityLimit && config.inactivityLimit > 1000
-        ? config.inactivityLimit
-        : 120000; // Default to 2 minutes
+      // Convert inactivityLimit from minutes to milliseconds
+      const inactivityLimitMs = config.inactivityLimit * 60 * 1000;
 
       const monitorAudioSilence = async () => {
         try {

src/bots/MicrosoftTeamsBot.ts

@@ -293,7 +293,7 @@ export class ZoomBot extends BotBase {
     // Wait in waiting room
     try {
       const wanderingTime = config.joinWaitTime * 60 * 1000; // Give some time to be let in
-      
+
       let waitTimeout: NodeJS.Timeout;
       let waitInterval: NodeJS.Timeout;
       const waitAtLobbyPromise = new Promise<boolean>((resolveMe) => {
@@ -355,7 +355,8 @@ export class ZoomBot extends BotBase {
 
         this._logger.error('Cant finish wait at the lobby check', { userDenied, waitingAtLobbySuccess: joined, bodyText });
 
-        throw new WaitingAtLobbyRetryError('Zoom bot could not enter the meeting...', bodyText ?? '', !userDenied, 2);
+        // Don't retry lobby errors - if user doesn't admit bot, retrying won't help
+        throw new WaitingAtLobbyRetryError('Zoom bot could not enter the meeting...', bodyText ?? '', false, 0);
       }
 
       this._logger.info('Bot is entering the meeting after wait room...');

src/bots/ZoomBot.ts

@@ -60,7 +60,9 @@ export default {
   inactivityLimit: process.env.MEETING_INACTIVITY_MINUTES ? Number(process.env.MEETING_INACTIVITY_MINUTES) : 1,
   activateInactivityDetectionAfter: process.env.INACTIVITY_DETECTION_START_DELAY_MINUTES ? Number(process.env.INACTIVITY_DETECTION_START_DELAY_MINUTES) :  1,
   serviceKey: process.env.SCREENAPP_BACKEND_SERVICE_API_KEY,
-  joinWaitTime: 10,
+  joinWaitTime: process.env.JOIN_WAIT_TIME_MINUTES ? Number(process.env.JOIN_WAIT_TIME_MINUTES) : 10,
+  // Number of retries for transient errors (not applied to WaitingAtLobbyRetryError)
+  retryCount: process.env.RETRY_COUNT ? Number(process.env.RETRY_COUNT) : 2,
   miscStorageBucket: process.env.GCP_MISC_BUCKET,
   miscStorageFolder: process.env.GCP_MISC_BUCKET_FOLDER ? process.env.GCP_MISC_BUCKET_FOLDER : 'meeting-bot',
   region: process.env.GCP_DEFAULT_REGION,