Skip to content

Pull request out-of-sync modal keeps appearing even after PR sync #3448

@yk634

Description

@yk634

What happened:
A modal saying "It appears that pull requests for this pipeline are out of sync" keeps appearing continuously.

Even after clicking the Sync button and successfully running the PR sync, when we click the Pull Request tab again, the same modal is shown repeatedly.

Based on our investigation, this seems to happen in the following situations:

  1. For pipelines with sourceDirectory configured, pull request jobs unrelated to the pipeline can sometimes be created (for example, when the branch differs).

    • In such cases, PR jobs are created, but corresponding pipeline events are not.
    • As a result, the system appears to judge that there are pull requests that require syncing, which causes the modal to be shown.
  2. In our environment, we periodically delete old events, builds, and archived job data from the database to reduce data volume.

    • When there are old pull requests that remain open, only the event data may be deleted while the PR job records remain.
    • This also causes the system to determine that there are PRs requiring sync, and the modal keeps appearing.

What you expected to happen:

At minimum, once Sync PR has been executed successfully, the modal should be dismissed and not shown again unless there is a new actual mismatch that requires syncing.

How to reproduce it:

  1. Create a pipeline with sourceDirectory configured.
  2. Create or update a pull request (e.g. on a different branch or unrelated to the pipeline), and trigger PR Sync by any means.
  3. Open the pipeline page and click the Pull Request tab.
  4. Observe that the modal "It appears that pull requests for this pipeline are out of sync" is displayed.
  5. Click Sync to run PR sync.
  6. Click the Pull Request tab again.
  7. Observe that the same modal is displayed again, even though PR sync was already executed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions