fix: correct unit descriptions

jim80net · jim80net · commit a2d7b55a62b8 · 2020-04-27T16:02:45.000-07:00
diff --git a/lib/slowlog_check.rb b/lib/slowlog_check.rb
@@ -247,17 +247,17 @@ def metric_metadatas
         "statsd_interval" => 60,
         "per_unit" => nil,
         "type" => "gauge",
-        "unit" => "µs"
+        "unit" => "microsecond"
       }
     }.push(
       {
         "name" => @metricname + '.count',
         "type" => 'rate',
         "description" => 'slowlog entries per minute',
         "short_name" => 'per minute',
-        "per_unit" => 'entry',
+        "per_unit" => 'minute',
         "integration" => nil,
-        "unit" => 'entries',
+        "unit" => 'entry',
         "statsd_interval" => 60
       }
     )
diff --git a/spec/slowlog_check_spec.rb b/spec/slowlog_check_spec.rb
@@ -280,7 +280,7 @@
           "statsd_interval"=>60,
           "per_unit"=>nil,
           "type"=>"gauge",
-          "unit"=>"µs"
+          "unit"=>"microsecond"
         }
         ]
       }
@@ -295,9 +295,9 @@
           "short_name"=>"per minute",
           "integration"=>nil,
           "statsd_interval"=>60,
-          "per_unit"=>"entry",
+          "per_unit"=>"minute",
           "type"=>"rate",
-          "unit"=>"entries"
+          "unit"=>"entry"
         }
       }
       it { is_expected.to contain_exactly(diff) }
@@ -309,11 +309,11 @@
         {
           description: 'slowlog entries per minute',
           integration: nil,
-          per_unit: 'entry',
+          per_unit: 'minute',
           short_name: 'per minute',
           statsd_interval: 60,
           type: 'rate',
-          unit: 'entries'
+          unit: 'entry'
         }
       }
       it 'sends the right data to datadog' do

Original file line number	Diff line number	Diff line change
`@@ -247,17 +247,17 @@ def metric_metadatas`
`247`	`247`	`"statsd_interval" => 60,`
`248`	`248`	`"per_unit" => nil,`
`249`	`249`	`"type" => "gauge",`
`250`		`- "unit" => "µs"`
	`250`	`+ "unit" => "microsecond"`
`251`	`251`	`}`
`252`	`252`	`}.push(`
`253`	`253`	`{`
`254`	`254`	`"name" => @metricname + '.count',`
`255`	`255`	`"type" => 'rate',`
`256`	`256`	`"description" => 'slowlog entries per minute',`
`257`	`257`	`"short_name" => 'per minute',`
`258`		`- "per_unit" => 'entry',`
	`258`	`+ "per_unit" => 'minute',`
`259`	`259`	`"integration" => nil,`
`260`		`- "unit" => 'entries',`
	`260`	`+ "unit" => 'entry',`
`261`	`261`	`"statsd_interval" => 60`
`262`	`262`	`}`
`263`	`263`	`)`
Original file line number	Diff line number	Diff line change
`@@ -280,7 +280,7 @@`
`280`	`280`	`"statsd_interval"=>60,`
`281`	`281`	`"per_unit"=>nil,`
`282`	`282`	`"type"=>"gauge",`
`283`		`- "unit"=>"µs"`
	`283`	`+ "unit"=>"microsecond"`
`284`	`284`	`}`
`285`	`285`	`]`
`286`	`286`	`}`
`@@ -295,9 +295,9 @@`
`295`	`295`	`"short_name"=>"per minute",`
`296`	`296`	`"integration"=>nil,`
`297`	`297`	`"statsd_interval"=>60,`
`298`		`- "per_unit"=>"entry",`
	`298`	`+ "per_unit"=>"minute",`
`299`	`299`	`"type"=>"rate",`
`300`		`- "unit"=>"entries"`
	`300`	`+ "unit"=>"entry"`
`301`	`301`	`}`
`302`	`302`	`}`
`303`	`303`	`it { is_expected.to contain_exactly(diff) }`
`@@ -309,11 +309,11 @@`
`309`	`309`	`{`
`310`	`310`	`description: 'slowlog entries per minute',`
`311`	`311`	`integration: nil,`
`312`		`- per_unit: 'entry',`
	`312`	`+ per_unit: 'minute',`
`313`	`313`	`short_name: 'per minute',`
`314`	`314`	`statsd_interval: 60,`
`315`	`315`	`type: 'rate',`
`316`		`- unit: 'entries'`
	`316`	`+ unit: 'entry'`
`317`	`317`	`}`
`318`	`318`	`}`
`319`	`319`	`it 'sends the right data to datadog' do`