Skip to content

Commit 11583b5

Browse files
authored
Merge pull request #81 from scribd/helen/SERF-2048/commit-message-check
[SERF-2048] Relax the requirement in PR commit message check workflow
2 parents 405d8e7 + 867a6e3 commit 11583b5

File tree

2 files changed

+5
-16
lines changed

2 files changed

+5
-16
lines changed

.github/workflows/pr-check.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: 'Commit Message Check'
1+
name: Commit Message Check
22
on:
33
pull_request:
44
types:
@@ -12,11 +12,11 @@ jobs:
1212
name: Check Commit Message
1313
runs-on: ubuntu-20.04
1414
steps:
15-
- name: Check Commit Message Title
15+
- name: Check Commit Message
1616
uses: gsactions/commit-message-checker@v2
1717
with:
18-
pattern: '^(?:feat|fix|docs|style|refactor|perf|test|chore)\(?(?:\w+|\s|\-|_)?\)?:\s[A-Z]\w+'
19-
error: 'The commit title does not follow the requirements. Please check the commit message requirements here: https://github.com/scribd/go-sdk#commit-messages'
18+
pattern: '^(?:ci|feat|fix|docs|style|refactor|perf|test|chore)\(?(?:\w+|\s|\-|_)?\)?:\s\w+'
19+
error: "One or more commit messages do not meet the format requirements. Please check the requirements here: https://github.com/scribd/go-sdk#commit-messages"
2020
accessToken: ${{ secrets.GITHUB_TOKEN }}
2121
excludeTitle: true
2222
excludeDescription: true

README.md

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1471,18 +1471,7 @@ In this case, perform the following steps:
14711471

14721472
### Commit messages
14731473

1474-
In order to generate a consistent and readable CHANGELOG, the commit title should being with a capital letter.
1475-
1476-
Examples:
1477-
```
1478-
// incorrect
1479-
feat(ci): some CI changes
1480-
1481-
// correct
1482-
feat(ci): Some CI changes
1483-
```
1484-
1485-
[The GitHub workflow checks the commit title correctness](https://github.com/scribd/go-sdk/blob/main/.github/workflows/pr-check.yml).
1474+
Please follow [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) and [Angular commit message guidelines](https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#-commit-message-guidelines) for writing commit messages.
14861475

14871476
## Release
14881477

0 commit comments

Comments
 (0)