Skip to content

Commit a41018b

Browse files
committed
fix: single quote(') in commit_message would lead to failure
1 parent 4623574 commit a41018b

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
with:
4141
token: ${{ secrets.SCRIBD_SLACK_GENERIC_TOKEN_PUBLIC }}
4242
channel: test-release-notification
43-
message: <https://scribd.com|Special characters + "quotes" + `backtick`>
43+
message: <https://scribd.com|Special characters + 'single quote' + "double quotes" + `backtick`>
4444
test-overwrite-repository:
4545
runs-on: ubuntu-22.04
4646
steps:

action.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ runs:
2828
using: composite
2929
steps:
3030
- name: Set fields
31+
env:
32+
input_message: ${{ inputs.message }}
33+
commit_message: ${{ github.event.head_commit.message }}
3134
shell: bash
3235
if: always()
3336
id: fields
@@ -43,11 +46,11 @@ runs:
4346
echo "color=warning" >> $GITHUB_OUTPUT
4447
fi
4548
46-
if [ ! -z '${{ inputs.message }}' ]; then
47-
message='${{ inputs.message }}'
48-
elif [ ! -z '${{ github.event.head_commit.message }}' ]; then
49+
if [ ! -z "$input_message" ]; then
50+
message=$input_message
51+
elif [ ! -z "$commit_message" ]; then
4952
# get commit message from `push` trigger
50-
commit_message=$(echo '${{ github.event.head_commit.message }}' | head -n 1)
53+
commit_message=$(echo "$commit_message" | head -n 1)
5154
message="<https://github.com/${{ inputs.repository }}/commit/${{ github.sha }}|$commit_message>"
5255
elif git rev-parse --is-inside-git-dir > /dev/null 2>&1; then
5356
# get commit message from the current git directory to support `workflow_dispatch` trigger

0 commit comments

Comments
 (0)