Skip to content

Commit c1cb8a5

Browse files
authored
Merge pull request #1 from scribd/helen/SERF-2441/itgc
[SERF-2441] Pass ITGC compliance checks
2 parents 040725d + 3c9cba8 commit c1cb8a5

File tree

3 files changed

+59
-0
lines changed

3 files changed

+59
-0
lines changed

.github/pull_request_template.md

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
## Description
2+
3+
<!-- This section should contain a short summary of the changes. -->
4+
5+
<!-- Please describe the problem you are trying to solve and why those changes are necessary. -->
6+
7+
<!-- If this PR fixes a bug or resolves a feature request, be sure to link to that issue. -->
8+
9+
## Testing considerations
10+
11+
<!-- Describe the tests or steps that you ran to verify your changes. -->
12+
13+
## Checklist
14+
15+
<!-- Please make sure all of the items below are checked before requesting a review: -->
16+
17+
- [ ] Prefixed the PR title with the JIRA ticket code <!-- e.g. `[JIRXXX] Add <XYZ> repository` -->
18+
- [ ] Performed simple, atomic commits with [good commit messages][commit messages]
19+
- [ ] Verified that the commit history is linear and commits are squashed as necessary
20+
- [ ] Thoroughly tested the changes in `development` and/or `staging`
21+
- [ ] Updated the `README.md` as necessary
22+
23+
<!-- Feel free to open a draft PR to get feedback early. -->
24+
25+
## Related links
26+
27+
<!-- This is a list of links, like the Jira ticket that contains additional context -->
28+
<!-- and other links to relevant documents, merge requests or discussions. -->
29+
30+
* [#XYZ](https://github.com/scribd/REPO/pull/XYZ)
31+
* [JIRXXX](https://scribdjira.atlassian.net/browse/JIRXXX)
32+
* [Design Document](https://scribdjira.atlassian.net/wiki/spaces/SPACEID/pages/PAGEID)
33+
* [Slack discussion](https://scribd.slack.com/archives/C0DSL144T/p1564610596278400)
34+
35+
[commit messages]: https://chris.beams.io/posts/git-commit/

.github/workflows/ci.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
name: CI
2+
3+
on: push
4+
5+
jobs:
6+
shared-workflow:
7+
uses: scribd/github-actions-shared-workflows/.github/workflows/shared-workflow.yml@main
8+
secrets:
9+
github_access_token: ${{ secrets.SCRIBD_GITHUB_GENERIC_TOKEN }}

CODEOWNERS

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# CODEOWNERS - Code ownership rules
2+
#
3+
# Ownership rules will be used automatically for suggesting reviewers on pull
4+
# requests.
5+
#
6+
# Rules should follow the standard of a file matching pattern followed by a
7+
# team name, e.g. @scribd/service-foundations. Do not use broad teams, such as
8+
# "Engineering", for code ownership.
9+
#
10+
# All lines starting with a `#` are comments and will be ignored.
11+
#
12+
# Order is important. The last matching pattern wins.
13+
14+
# Service Foundations parent ownership
15+
* @scribd/service-foundations

0 commit comments

Comments
 (0)