fix: close file descriptor after download rename

Qingping Hou · Qingping Hou · commit 9430b5877a66 · 2020-03-22T01:47:42.000-07:00
diff --git a/pkg/sync/pull.go b/pkg/sync/pull.go
@@ -104,6 +104,7 @@ func (self *Puller) downloadHandler(task DownloadTask, downloader GenericDownloa
 		self.errMsgQueue <- fmt.Sprintf("Failed to create file %s for download: %v", tmpfile.Name(), err)
 		return
 	}
+	defer tmpfile.Close()
 
 	downloader.Download(tmpfile, &s3.GetObjectInput{
 		Bucket: aws.String(bucket),

Original file line number	Diff line number	Diff line change
`@@ -104,6 +104,7 @@ func (self *Puller) downloadHandler(task DownloadTask, downloader GenericDownloa`
`104`	`104`	`self.errMsgQueue <- fmt.Sprintf("Failed to create file %s for download: %v", tmpfile.Name(), err)`
`105`	`105`	`return`
`106`	`106`	`}`
	`107`	`+ defer tmpfile.Close()`
`107`	`108`
`108`	`109`	`downloader.Download(tmpfile, &s3.GetObjectInput{`
`109`	`110`	`Bucket: aws.String(bucket),`