Skip to content

Commit c74df14

Browse files
authored
Merge pull request #29 from scribd/DATAPLAT-260_fix
DATAPLAT-260: fix error in role policy
2 parents a3b7a58 + 3775848 commit c74df14

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

main.tf

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -747,10 +747,6 @@ data "aws_iam_policy_document" "glue_create" {
747747
}
748748
statement {
749749
effect = "Allow"
750-
principals {
751-
type = "*"
752-
identifiers = ["*"]
753-
}
754750
actions = ["sqs:ReceiveMessage"]
755751
resources = [aws_sqs_queue.glue_create[0].arn]
756752

@@ -762,10 +758,6 @@ data "aws_iam_policy_document" "glue_create" {
762758
}
763759
statement {
764760
effect = "Allow"
765-
principals {
766-
type = "AWS"
767-
identifiers = ["*"]
768-
}
769761
actions = [
770762
"sqs:SendMessage"
771763
]
@@ -781,7 +773,7 @@ data "aws_iam_policy_document" "glue_create" {
781773
resource "aws_iam_policy" "glue_create_managed" {
782774
count = local.enable_glue_create ? 1 : 0
783775

784-
name = var.glue_create_config.iam_police_name
776+
name = var.glue_create_config.iam_policy_name
785777
description = "Glue create policy allows access to Athena and S3"
786778
policy = data.aws_iam_policy_document.glue_create[0].json
787779
tags = var.tags

variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,7 @@ variable "glue_create_config" {
317317
sqs_queue_name = string // name of sqs queue for glue-sync lambda
318318
sqs_queue_name_dl = string // name dead letter sqs que with not processed s3 events
319319
iam_role_name = string // lambda role name
320-
iam_police_name = string // lambda policy name
320+
iam_policy_name = string // lambda policy name
321321
})
322322
description = "Configuration of glue-create lambda"
323323
}

0 commit comments

Comments
 (0)