Skip to content

Commit 66aafb1

Browse files
danmichaelodanmichaelo
committed
Apply fixes from StyleCI
1 parent b12769b commit 66aafb1

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+179
-139
lines changed

‎spec/Analytics/ReportSpec.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
use PhpSpec\ObjectBehavior;
66
use Scriptotek\Alma\Analytics\Report;
77
use Scriptotek\Alma\Analytics\Row;
8-
use Scriptotek\Alma\Analytics\Rows;
98
use Scriptotek\Alma\Client;
109
use Scriptotek\Alma\Exception\ResourceNotFound;
1110
use spec\Scriptotek\Alma\SpecHelper;

‎spec/Bibs/BibSpec.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
use Prophecy\Argument;
77
use Scriptotek\Alma\Bibs\Bib;
88
use Scriptotek\Alma\Bibs\Bibs;
9-
use Scriptotek\Alma\Bibs\Holding;
109
use Scriptotek\Alma\Bibs\Holdings;
1110
use Scriptotek\Alma\Client as AlmaClient;
1211
use Scriptotek\Alma\Exception\ResourceNotFound;

‎spec/Bibs/HoldingSpec.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
namespace spec\Scriptotek\Alma\Bibs;
44

55
use PhpSpec\ObjectBehavior;
6-
use Prophecy\Argument;
76
use Scriptotek\Alma\Bibs\Bib;
87
use Scriptotek\Alma\Bibs\Holding;
98
use Scriptotek\Alma\Bibs\Item;

‎spec/Bibs/HoldingsSpec.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
namespace spec\Scriptotek\Alma\Bibs;
44

55
use PhpSpec\ObjectBehavior;
6-
use Prophecy\Argument;
76
use Scriptotek\Alma\Bibs\Bib;
87
use Scriptotek\Alma\Bibs\Holding;
98
use Scriptotek\Alma\Bibs\Holdings;

‎spec/Bibs/ItemSpec.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
use Scriptotek\Alma\Bibs\Bib;
77
use Scriptotek\Alma\Bibs\Holding;
88
use Scriptotek\Alma\Bibs\Item;
9-
use Scriptotek\Alma\Client as AlmaClient;
109
use Scriptotek\Alma\Bibs\ScanInResponse;
10+
use Scriptotek\Alma\Client as AlmaClient;
1111
use Scriptotek\Alma\Conf\Library;
1212
use Scriptotek\Alma\Users\Loan;
1313
use Scriptotek\Alma\Users\Requests;
@@ -30,13 +30,13 @@ public function it_is_initializable()
3030
$this->shouldHaveType(Item::class);
3131
}
3232

33-
function it_can_be_checked_out(AlmaClient $client, User $user, Library $library)
33+
public function it_can_be_checked_out(AlmaClient $client, User $user, Library $library)
3434
{
3535
$client->postJSON(
3636
'/bibs/990006312214702204/holdings/22163771200002204/items/23163771190002204/loans?user_id=Dan+Michael',
3737
[
38-
'library' => ['value' => 'THAT LIBRARY'],
39-
'circ_desk' => ['value' => 'DEFAULT_CIRC_DESK']
38+
'library' => ['value' => 'THAT LIBRARY'],
39+
'circ_desk' => ['value' => 'DEFAULT_CIRC_DESK'],
4040
]
4141
)
4242
->shouldBeCalled()
@@ -49,7 +49,7 @@ function it_can_be_checked_out(AlmaClient $client, User $user, Library $library)
4949
->shouldHaveType(Loan::class);
5050
}
5151

52-
function it_can_be_on_loan(AlmaClient $client, User $user, Library $library)
52+
public function it_can_be_on_loan(AlmaClient $client, User $user, Library $library)
5353
{
5454
$client->getJSON('/bibs/990006312214702204/holdings/22163771200002204/items/23163771190002204/loans')
5555
->shouldBeCalled()
@@ -59,7 +59,7 @@ function it_can_be_on_loan(AlmaClient $client, User $user, Library $library)
5959
$this->loan->shouldHaveType(Loan::class);
6060
}
6161

62-
function it_can_be_available(AlmaClient $client, User $user, Library $library)
62+
public function it_can_be_available(AlmaClient $client, User $user, Library $library)
6363
{
6464
$client->getJSON('/bibs/990006312214702204/holdings/22163771200002204/items/23163771190002204/loans')
6565
->shouldBeCalled()
@@ -69,7 +69,7 @@ function it_can_be_available(AlmaClient $client, User $user, Library $library)
6969
$this->loan->shouldBe(null);
7070
}
7171

72-
function it_can_be_scanned_in(AlmaClient $client, Library $library)
72+
public function it_can_be_scanned_in(AlmaClient $client, Library $library)
7373
{
7474
$client->postJSON('/bibs/990006312214702204/holdings/22163771200002204/items/23163771190002204?op=scan&library=THAT+LIBRARY&circ_desk=DEFAULT_CIRC_DESK')
7575
->shouldBeCalled()
@@ -81,7 +81,7 @@ function it_can_be_scanned_in(AlmaClient $client, Library $library)
8181
->shouldHaveType(ScanInResponse::class);
8282
}
8383

84-
function it_can_be_scanned_in_with_params(AlmaClient $client, Library $library)
84+
public function it_can_be_scanned_in_with_params(AlmaClient $client, Library $library)
8585
{
8686
$client->postJSON('/bibs/990006312214702204/holdings/22163771200002204/items/23163771190002204?place_on_hold_shelf=true&op=scan&library=THAT+LIBRARY&circ_desk=OTHER_DESK')
8787
->shouldBeCalled()

‎spec/Conf/LibrariesSpec.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33
namespace spec\Scriptotek\Alma\Conf;
44

5+
use PhpSpec\ObjectBehavior;
56
use Scriptotek\Alma\Client as AlmaClient;
67
use Scriptotek\Alma\Conf\Libraries;
78
use Scriptotek\Alma\Conf\Library;
8-
use PhpSpec\ObjectBehavior;
99
use spec\Scriptotek\Alma\SpecHelper;
1010

1111
class LibrariesSpec extends ObjectBehavior
@@ -15,14 +15,14 @@ public function let(AlmaClient $client)
1515
$this->beConstructedWith($client);
1616
}
1717

18-
function it_is_muh()
18+
public function it_is_muh()
1919
{
2020
$this->shouldBeAnInstanceOf(Libraries::class);
2121
$this->shouldImplement(\Countable::class);
2222
$this->shouldImplement(\Iterator::class);
2323
}
2424

25-
function it_provides_a_lazy_interface_to_libary_objects(AlmaClient $client)
25+
public function it_provides_a_lazy_interface_to_libary_objects(AlmaClient $client)
2626
{
2727
SpecHelper::expectNoRequests($client);
2828

@@ -33,7 +33,7 @@ function it_provides_a_lazy_interface_to_libary_objects(AlmaClient $client)
3333
$library->code->shouldBe($libraryCode);
3434
}
3535

36-
function it_provides_libraries(AlmaClient $client)
36+
public function it_provides_libraries(AlmaClient $client)
3737
{
3838
$client->getJSON('/conf/libraries')
3939
->shouldBeCalled()

‎spec/Conf/LibrarySpec.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,9 @@
22

33
namespace spec\Scriptotek\Alma\Conf;
44

5+
use PhpSpec\ObjectBehavior;
56
use Scriptotek\Alma\Client as AlmaClient;
67
use Scriptotek\Alma\Conf\Library;
7-
use PhpSpec\ObjectBehavior;
8-
use Prophecy\Argument;
98
use Scriptotek\Alma\Conf\Locations;
109

1110
class LibrarySpec extends ObjectBehavior
@@ -16,12 +15,12 @@ public function let(AlmaClient $client)
1615
$this->beConstructedWith($client, $libraryCode);
1716
}
1817

19-
function it_is_initializable()
18+
public function it_is_initializable()
2019
{
2120
$this->shouldHaveType(Library::class);
2221
}
2322

24-
function it_should_have_locations()
23+
public function it_should_have_locations()
2524
{
2625
$this->locations->shouldBeAnInstanceOf(Locations::class);
2726
}

‎spec/Conf/LocationSpec.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,27 +2,25 @@
22

33
namespace spec\Scriptotek\Alma\Conf;
44

5+
use PhpSpec\ObjectBehavior;
56
use Scriptotek\Alma\Client as AlmaClient;
67
use Scriptotek\Alma\Conf\Library;
78
use Scriptotek\Alma\Conf\Location;
8-
use PhpSpec\ObjectBehavior;
9-
use Prophecy\Argument;
109

1110
class LocationSpec extends ObjectBehavior
1211
{
13-
1412
public function let(AlmaClient $client, Library $library)
1513
{
1614
$location_code = 'sq10s9pg';
1715
$this->beConstructedWith($client, $library, $location_code);
1816
}
1917

20-
function it_is_initializable()
18+
public function it_is_initializable()
2119
{
2220
$this->shouldHaveType(Location::class);
2321
}
2422

25-
function it_should_belong_to_a_library()
23+
public function it_should_belong_to_a_library()
2624
{
2725
$this->library->shouldBeAnInstanceOf(Library::class);
2826
}

‎spec/Conf/LocationsSpec.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33
namespace spec\Scriptotek\Alma\Conf;
44

5+
use PhpSpec\ObjectBehavior;
56
use Scriptotek\Alma\Client as AlmaClient;
67
use Scriptotek\Alma\Conf\Library;
78
use Scriptotek\Alma\Conf\Location;
8-
use PhpSpec\ObjectBehavior;
99
use spec\Scriptotek\Alma\SpecHelper;
1010

1111
class LocationsSpec extends ObjectBehavior
@@ -16,7 +16,7 @@ public function let(AlmaClient $client, Library $library)
1616
$this->beConstructedWith($client, $library);
1717
}
1818

19-
function it_provides_a_lazy_interface_to_location_objects(AlmaClient $client)
19+
public function it_provides_a_lazy_interface_to_location_objects(AlmaClient $client)
2020
{
2121
SpecHelper::expectNoRequests($client);
2222

@@ -27,7 +27,7 @@ function it_provides_a_lazy_interface_to_location_objects(AlmaClient $client)
2727
$location->code->shouldBe($code);
2828
}
2929

30-
function it_provides_locations(AlmaClient $client)
30+
public function it_provides_locations(AlmaClient $client)
3131
{
3232
$client->getJSON('/conf/libraries/LIB_CODE/locations')
3333
->shouldBeCalled()

‎spec/TaskLists/LendingRequestsSpec.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,20 @@
22

33
namespace spec\Scriptotek\Alma\TaskLists;
44

5+
use PhpSpec\ObjectBehavior;
56
use Scriptotek\Alma\Client as AlmaClient;
67
use Scriptotek\Alma\Conf\Library;
7-
use PhpSpec\ObjectBehavior;
88
use Scriptotek\Alma\TaskLists\ResourceSharingRequest;
99
use spec\Scriptotek\Alma\SpecHelper;
1010

1111
class LendingRequestsSpec extends ObjectBehavior
1212
{
13-
function it_provides_filtering_options(AlmaClient $client, Library $library)
13+
public function it_provides_filtering_options(AlmaClient $client, Library $library)
1414
{
1515
$library->code = 'SOME_LIBRARY';
1616
$this->beConstructedWith($client, $library, [
1717
'printed' => 'N',
18-
'status' => 'REQUEST_CREATED_LEND',
18+
'status' => 'REQUEST_CREATED_LEND',
1919
]);
2020

2121
$client->getJSON('/task-lists/rs/lending-requests?printed=N&status=REQUEST_CREATED_LEND&library=SOME_LIBRARY')

0 commit comments

Comments
 (0)