Add extra test to avoid warning about Countable in PHP 7.3

danmichaelo · danmichaelo · commit 7a44ae711bd6 · 2019-04-04T12:13:44.000+02:00
diff --git a/src/Model/SimplePaginatedList.php b/src/Model/SimplePaginatedList.php
@@ -54,7 +54,11 @@ protected function onData($data)
      */
     protected function isInitialized($data)
     {
-        return count($data) === $this->totalRecordCount;
+        if (is_countable($data)) {
+            return count($data) === $this->totalRecordCount;
+        }
+
+        return false;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,11 @@ protected function onData($data)`
`54`	`54`	`*/`
`55`	`55`	`protected function isInitialized($data)`
`56`	`56`	`{`
`57`		`- return count($data) === $this->totalRecordCount;`
	`57`	`+ if (is_countable($data)) {`
	`58`	`+ return count($data) === $this->totalRecordCount;`
	`59`	`+ }`
	`60`	`+`
	`61`	`+ return false;`
`58`	`62`	`}`
`59`	`63`
`60`	`64`	`/**`