Fix: Parsing of Holding records

As with Bib records, use XML instead of JSON for Holding records. This also allows for editing Holding records in the future.

Fixes #9

Author: danmichaelo

README.md

@@ -259,6 +259,8 @@ $holding = $alma->bibs['990310361044702204']->holdings['22102913020002204'];
 $marcRecord = $holding->record;
 ```
 
+**Note:** Editing holding records is not yet supported. Will be added in the future.
+
 Items can be listed from holdings in the same manner as holdings can be fetched from bibs.
 Here's an example:
 

spec/Bibs/HoldingSpec.php

@@ -7,6 +7,7 @@
 use Scriptotek\Alma\Bibs\Holding;
 use Scriptotek\Alma\Bibs\Item;
 use Scriptotek\Alma\Client as AlmaClient;
+use Scriptotek\Marc\Record;
 use spec\Scriptotek\Alma\SpecHelper;
 
 class HoldingSpec extends ObjectBehavior
@@ -18,11 +19,28 @@ public function let(AlmaClient $client, Bib $bib)
         $this->beConstructedWith($client, $bib, $holdings_id);
     }
 
+    protected function expectRequest($client)
+    {
+        $client->getXML('/bibs/abc/holdings/123')
+            ->shouldBeCalled()
+            ->willReturn(SpecHelper::getDummyData('holding_response.xml'));
+    }
+
     public function it_is_initializable()
     {
         $this->shouldHaveType(Holding::class);
     }
 
+    public function it_fetches_record_data_when_needed(AlmaClient $client)
+    {
+        $this->expectRequest($client);
+
+        $this->created_by->shouldBe('import');
+        $this->created_date->shouldBe('2015-11-05Z');
+
+        $this->record->shouldHaveType(Record::class);
+    }
+
     public function it_has_items(AlmaClient $client)
     {
         $client->getJSON('/bibs/abc/holdings/123/items')

spec/Bibs/HoldingsSpec.php

@@ -103,4 +103,15 @@ public function it_provides_an_iterator_interface_to_holding_objects(AlmaClient
 
         $this->current()->shouldHaveType(Holding::class);
     }
+
+    public function it_provides_basic_data_without_loading_the_full_record(AlmaClient $client)
+    {
+        $client->getJSON('/bibs/abc/holdings')
+            ->shouldBeCalledTimes(1)
+            ->willReturn(json_decode($this->sample));
+
+        $this->shouldHaveCount(2);
+        $this->all()[0]->shouldHaveType(Holding::class);
+        $this->all()[0]->library->desc->shouldBe('BURNS');
+    }
 }

spec/data/holding_response.xml

@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="utf-8" standalone="yes"?>
+<holding>
+    <holding_id>22163771200002204</holding_id>
+    <created_by>import</created_by>
+    <created_date>2015-11-05Z</created_date>
+    <last_modified_by>System</last_modified_by>
+    <last_modified_date>2018-11-09Z</last_modified_date>
+    <originating_system>ILS</originating_system>
+    <originating_system_id>h449730-47bibsys_ubo</originating_system_id>
+    <suppress_from_publishing>false</suppress_from_publishing>
+    <record>
+        <leader>00384nx  a2200145ui 4500</leader>
+        <controlfield tag="001">h449730-47bibsys_ubo</controlfield>
+        <controlfield tag="004">000631221-47bibsys_ubo</controlfield>
+        <controlfield tag="007">ta</controlfield>
+        <controlfield tag="008">1511020l||||||||4   uu</controlfield>
+        <controlfield tag="009">kat</controlfield>
+        <controlfield tag="005">20181109134730.0</controlfield>
+        <datafield ind1="1" ind2=" " tag="014">
+            <subfield code="a">000631221</subfield>
+            <subfield code="b">(NO-TrBIB)</subfield>
+        </datafield>
+        <datafield ind1=" " ind2=" " tag="035">
+            <subfield code="a">00kj16342-47bibsys_ubo</subfield>
+        </datafield>
+        <datafield ind1="1" ind2=" " tag="852">
+            <subfield code="b">1030300</subfield>
+            <subfield code="c">k00041</subfield>
+            <subfield code="h">839.82</subfield>
+            <subfield code="i">Vol:Ban</subfield>
+        </datafield>
+        <datafield ind1=" " ind2=" " tag="876">
+            <subfield code="a">00kj16342</subfield>
+            <subfield code="d">20000529</subfield>
+            <subfield code="j">kat</subfield>
+            <subfield code="p">303011kj0</subfield>
+            <subfield code="r">00kj16342</subfield>
+            <subfield code="w">BOOK</subfield>
+        </datafield>
+    </record>
+</holding>

src/Bibs/Holding.php

@@ -2,6 +2,7 @@
 
 namespace Scriptotek\Alma\Bibs;
 
+use Danmichaelo\QuiteSimpleXMLElement\QuiteSimpleXMLElement;
 use Scriptotek\Alma\Client;
 use Scriptotek\Alma\Model\LazyResource;
 use Scriptotek\Marc\Record as MarcRecord;
@@ -31,16 +32,38 @@ public function __construct(Client $client, Bib $bib, $holding_id)
         $this->items = Items::make($this->client, $bib, $this);
     }
 
+    /**
+     * Get the model data.
+     */
+    protected function fetchData()
+    {
+        return $this->client->getXML($this->url());
+    }
+
     /**
      * Check if we have the full representation of our data object.
      *
-     * @param \stdClass $data
+     * @param $data
      *
      * @return bool
      */
     protected function isInitialized($data)
     {
-        return isset($data->anies);
+        return is_a($data, QuiteSimpleXMLElement::class) && $data->has('record');
+    }
+
+    /**
+     * Load MARC record onto this Bib object. Chainable method.
+     *
+     * @param string $xml
+     *
+     * @return Holding
+     */
+    public function setMarcRecord($xml)
+    {
+        $this->_marc = MarcRecord::fromString($xml);
+
+        return $this;
     }
 
     /**
@@ -50,7 +73,7 @@ protected function isInitialized($data)
      */
     protected function onData($data)
     {
-        $this->_marc = MarcRecord::fromString($data->anies[0]);
+        $this->setMarcRecord($data->first('record')->asXML());
     }
 
     /**