refactor: Let Field::sf() return null by default when no value found

danmichaelo · danmichaelo · commit 2f159274094b · 2017-10-30T23:47:58.000+01:00
diff --git a/src/Fields/Field.php b/src/Fields/Field.php
@@ -91,7 +91,7 @@ protected function toString($codes, $glue = ' ')
      * @param mixed $default
      * @return mixed
      */
-    public function sf($code, $default = '')
+    public function sf($code, $default = null)
     {
         $subfield = $this->getSubfield($code);
         if (!$subfield) {
diff --git a/src/Fields/Isbn.php b/src/Fields/Isbn.php
@@ -8,7 +8,7 @@ class Isbn extends Field implements FieldInterface
 {
     public function __toString()
     {
-        return $this->sf('a');
+        return $this->sf('a', '');
     }
 
     public static function get(Record $record)

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ protected function toString($codes, $glue = ' ')`
`91`	`91`	`* @param mixed $default`
`92`	`92`	`* @return mixed`
`93`	`93`	`*/`
`94`		`- public function sf($code, $default = '')`
	`94`	`+ public function sf($code, $default = null)`
`95`	`95`	`{`
`96`	`96`	`$subfield = $this->getSubfield($code);`
`97`	`97`	`if (!$subfield) {`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ class Isbn extends Field implements FieldInterface`
`8`	`8`	`{`
`9`	`9`	`public function __toString()`
`10`	`10`	`{`
`11`		`- return $this->sf('a');`
	`11`	`+ return $this->sf('a', '');`
`12`	`12`	`}`
`13`	`13`
`14`	`14`	`public static function get(Record $record)`