style: Use short array syntax

Author: danmichaelo

.styleci.yml

@@ -1,5 +1,4 @@
 preset: psr2
 
 enabled:
-  - long_array_syntax
   - concat_with_spaces

src/Collection.php

@@ -113,6 +113,6 @@ public function rewind()
 
     public function __call($name, $arguments)
     {
-        return call_user_func_array(array($this->parser, $name), $arguments);
+        return call_user_func_array([$this->parser, $name], $arguments);
     }
 }

src/Fields/Field.php

@@ -15,14 +15,14 @@ public function __construct(\File_MARC_Field $field)
 
     public function __call($name, $args)
     {
-        return call_user_func_array(array($this->field, $name), $args);
+        return call_user_func_array([$this->field, $name], $args);
     }
 
     public function __get($key)
     {
         $method = 'get' . ucfirst($key);
         if (method_exists($this, $method)) {
-            return call_user_func(array($this, $method));
+            return call_user_func([$this, $method]);
         }
     }
 

src/Fields/Subject.php

@@ -24,7 +24,7 @@ class Subject extends Field implements FieldInterface
     const CURRICULUM_OBJECTIVE = '658';
     const HIERARCHICAL_PLACE_NAME = '662';
 
-    protected $vocabularies = array(
+    protected $vocabularies = [
         '0' => 'lcsh',  // 0: Library of Congress Subject Headings
         '1' => 'lccsh', // 1: LC subject headings for children's literature
         '2' => 'mesh',  // 2: Medical Subject Headings
@@ -33,7 +33,7 @@ class Subject extends Field implements FieldInterface
         '5' => 'cash',  // 5: Canadian Subject Headings
         '6' => 'rvm',   // 6: Répertoire de vedettes-matière
         // 7: Source specified in subfield $2
-    );
+    ];
 
     public static function get(Record $record)
     {
@@ -70,9 +70,9 @@ public function getControlNumber()
 
     public function getParts()
     {
-        $parts = array();
+        $parts = [];
         foreach ($this->field->getSubfields() as $c) {
-            if (in_array($c->getCode(), array('a', 'b', 'x', 'y', 'z'))) {
+            if (in_array($c->getCode(), ['a', 'b', 'x', 'y', 'z'])) {
                 $parts[] = $c->getData();
             }
         }

src/Fields/Title.php

@@ -27,7 +27,7 @@ public function __toString()
         // $b is not repeated
         $b = $this->field->getSubfield('b');
         if ($b) {
-            if (!in_array(substr($title, strlen($title) - 1), array(':', ';', '=', '.'))) {
+            if (!in_array(substr($title, strlen($title) - 1), [':', ';', '=', '.'])) {
                 // Add colon if no ISBD marker present ("British style")
                 $title .= ' :';
             }
@@ -36,7 +36,7 @@ public function __toString()
 
         // Part number and title can be repeated
         foreach ($this->field->getSubfields() as $sf) {
-            if (in_array($sf->getCode(), array('n', 'p'))) {
+            if (in_array($sf->getCode(), ['n', 'p'])) {
                 $title .= ' ' . $sf->getData();
             }
         }

src/Importers/XmlImporter.php

@@ -31,13 +31,13 @@ public function getMarcNamespace($namespaces)
     {
         foreach ($namespaces as $prefix => $ns) {
             if ($ns == 'info:lc/xmlns/marcxchange-v1') {
-                return array($prefix, $ns);
+                return [$prefix, $ns];
             } elseif ($ns == 'http://www.loc.gov/MARC21/slim') {
-                return array($prefix, $ns);
+                return [$prefix, $ns];
             }
         }
 
-        return array('', '');
+        return ['', ''];
     }
 
     public function getRecords()
@@ -47,7 +47,7 @@ public function getRecords()
 
         // If root node is record:
         if ($this->source->getName() == 'record') {
-            return array($this->source);
+            return [$this->source];
         }
 
         $marcRecords = $this->source->xpath('.//x:record');
@@ -63,7 +63,7 @@ public function getRecords()
             return $marcRecords;
         }
 
-        return array();
+        return [];
     }
 
     public function getCollection()

src/Record.php

@@ -194,14 +194,14 @@ public function getSubjects($vocabulary = null, $tag = null)
 
     public function __call($name, $args)
     {
-        return call_user_func_array(array($this->record, $name), $args);
+        return call_user_func_array([$this->record, $name], $args);
     }
 
     public function __get($key)
     {
         $method = 'get' . ucfirst($key);
         if (method_exists($this, $method)) {
-            return call_user_func(array($this, $method));
+            return call_user_func([$this, $method]);
         }
     }