Cleanup

Author: danmichaelo

src/Fields/Subject.php

@@ -39,6 +39,12 @@ public function getControlNumber($value='')
         return $this->field->getSubfield('0');
     }
 
+    /**
+     * Returns the title of the record (245 $a, $b, $n and $p).
+     *  - Joins the subfields by colon if no ISBD marker present at the end of $a
+     *  - Removes trailing '/'
+     *  - See tests/TitleFieldTest.php for more info.
+     */
     public function __toString()
     {
         $parts = array();

src/Fields/Title.php

@@ -4,8 +4,12 @@
 
 class Title extends Field implements FieldInterface
 {
+
     /**
-     * See tests/TitleFieldTest.php for more info.
+     * Returns the string representation $a, $b, $n and $p).
+     *  - Joins the subfields by colon if no ISBD marker present at the end of $a
+     *  - Removes trailing '/'
+     *  - See tests/TitleFieldTest.php for more info.
      */
     public function __toString()
     {

src/Record.php

@@ -24,7 +24,12 @@ public static function fromString($data)
     {
         $collection = Collection::fromString($data);
 
-        return $collection->records->toArray()[0];
+        $recs = $collection->records->toArray();
+        if (!count($recs)) {
+            throw new \ErrorException('Record not found');
+        }
+
+        return $recs[0];
     }
 
     /*************************************************************************
@@ -93,11 +98,11 @@ public function getSubjects($vocabulary = null, $type = null)
             '653' => 'uncontrolled',   # Index Term - Uncontrolled
              // 654 :  Subject Added Entry - Faceted Topical Terms
             '655' => 'form',           # Index Term - Genre/Form
-             // 657 - Index Term - Function (R) Full | Concise
-             // 658 - Index Term - Curriculum Objective (R) Full | Concise
-             // 662 - Subject Added Entry - Hierarchical Place Name (R) Full | Concise
-             // 69X - Local Subject Access Fields (R) Full | Concise
             '656' => 'occupation',     # Index Term - Occupation
+             // 657 - Index Term - Function
+             // 658 - Index Term - Curriculum Objective
+             // 662 - Subject Added Entry - Hierarchical Place Name
+             // 69X - Local Subject Access Fields
         );
         foreach ($saf as $k => $v) {
             foreach ($this->record->getFields($k) as $field) { // or 655, 648, etc.
@@ -156,4 +161,5 @@ public function __toString()
     {
         return strval($this->record);
     }
+
 }