Don't throw exception on empty set

Author: danmichaelo

src/Collection.php

@@ -56,9 +56,8 @@ public function parse($source, $isXml, $ns = '', $isPrefix = true)
     public function __get($key = '')
     {
         if ($key == 'records') {
-            // re-instantiaces..
             if (is_null($this->parser)) {
-                return array();
+                $this->_records = new Records();
             }
             if (is_null($this->_records)) {
                 $this->_records = new Records($this->parser);

src/Importers/XmlImporter.php

@@ -63,7 +63,7 @@ public function getCollection()
     {
         $records = $this->getRecords();
         if (!count($records)) {
-            throw new \ErrorException("Uh oh, didn't find any records");
+            return $this->collection;
         }
 
         list($prefix, $ns) = $this->getMarcNamespace($records[0]->getNamespaces(true));

src/Records.php

@@ -8,7 +8,7 @@ class Records implements \Iterator //, \Countable
     protected $records;
     protected $useCache = false;
 
-    public function __construct($parser)
+    public function __construct($parser = null)
     {
         $this->parser = $parser;
         $this->_current = null;
@@ -27,7 +27,7 @@ public function toArray()
     }
 
     /*********************************************************
-     * Iterator + Countable
+     * Iterator
      *********************************************************/
 
     protected $position = 0;
@@ -49,7 +49,7 @@ public function next()
         if ($this->useCache) {
             $rec = isset($this->records[$this->position]) ? $this->records[$this->position] : false;
         } else {
-            $rec = $this->parser->next();
+            $rec = $this->parser ? $this->parser->next() : null;
             if ($rec) {
                 $rec = new Record($rec);
                 $this->records[] = $rec;

tests/SruResponseTest.php

@@ -2,7 +2,7 @@
 
 use Scriptotek\Marc\Importers\XmlImporter;
 
-class XmlImporterTest extends \PHPUnit_Framework_TestCase
+class SruResponseImporterTest extends \PHPUnit_Framework_TestCase
 {
     public function testLocSample()
     {

tests/XmlImporterTest.php

@@ -0,0 +1,13 @@
+<?php
+
+use Scriptotek\Marc\Importers\XmlImporter;
+
+class XmlImporterTest extends \PHPUnit_Framework_TestCase
+{
+    public function testEmptySet()
+    {
+        $response = new XmlImporter('<records></records>');
+
+        $this->assertCount(0, $response->getCollection()->records);
+    }
+}