Skip to content

Commit d07b0f6

Browse files
committed
Use XmlImporter for SRU and OAI-PMH responses
No need for specific importers for SRU and OAI-PMH respones anymore. With the rewrite of XmlImporter, it ignores *any* container XML.
1 parent 87c05af commit d07b0f6

File tree

5 files changed

+11
-37
lines changed

5 files changed

+11
-37
lines changed

src/Importers/OaiPmhResponse.php

Lines changed: 0 additions & 13 deletions
This file was deleted.

src/Importers/SruResponse.php

Lines changed: 0 additions & 13 deletions
This file was deleted.

tests/OaiPmhResponseTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
<?php
22

3-
use Scriptotek\Marc\Importers\OaiPmhResponse;
3+
use Scriptotek\Marc\Importers\XmlImporter;
44

55
class OaiPmhResponseTest extends \PHPUnit_Framework_TestCase
66
{
77
public function testBibsysSample()
88
{
9-
$response = new OaiPmhResponse('tests/data/oaipmh-bibsys.xml');
9+
$response = new XmlImporter('tests/data/oaipmh-bibsys.xml');
1010

1111
$this->assertCount(89, $response->getRecords());
1212
}

tests/SruResponseTest.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,40 @@
11
<?php
22

3-
use Scriptotek\Marc\Importers\SruResponse;
3+
use Scriptotek\Marc\Importers\XmlImporter;
44

5-
class SruResponseTest extends \PHPUnit_Framework_TestCase
5+
class XmlImporterTest extends \PHPUnit_Framework_TestCase
66
{
77
public function testLocSample()
88
{
9-
$response = new SruResponse('tests/data/sru-loc.xml');
9+
$response = new XmlImporter('tests/data/sru-loc.xml');
1010

1111
$this->assertCount(10, $response->getRecords());
1212
}
1313

1414
public function testBibsysSample()
1515
{
16-
$response = new SruResponse('tests/data/sru-bibsys.xml');
16+
$response = new XmlImporter('tests/data/sru-bibsys.xml');
1717

1818
$this->assertCount(117, $response->getRecords());
1919
}
2020

2121
public function testZdbSample()
2222
{
23-
$response = new SruResponse('tests/data/sru-zdb.xml');
23+
$response = new XmlImporter('tests/data/sru-zdb.xml');
2424

2525
$this->assertCount(8, $response->getRecords());
2626
}
2727

2828
public function testKthSample()
2929
{
30-
$response = new SruResponse('tests/data/sru-kth.xml');
30+
$response = new XmlImporter('tests/data/sru-kth.xml');
3131

3232
$this->assertCount(10, $response->getRecords());
3333
}
3434

3535
public function testAlmaSample()
3636
{
37-
$response = new SruResponse('tests/data/sru-alma.xml');
37+
$response = new XmlImporter('tests/data/sru-alma.xml');
3838

3939
$this->assertCount(3, $response->getRecords());
4040
}

tests/SubjectFieldTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
<?php
22

3-
use Scriptotek\Marc\Importers\SruResponse;
3+
use Scriptotek\Marc\Importers\XmlImporter;
44

55
class SubjectFieldTest extends \PHPUnit_Framework_TestCase
66
{
77
protected function getNthrecord($n)
88
{
9-
$response = new SruResponse('tests/data/sru-alma.xml');
9+
$response = new XmlImporter('tests/data/sru-alma.xml');
1010
$collection = $response->getCollection();
1111

1212
$records = $collection->records;

0 commit comments

Comments
 (0)